Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log to 8.1 #1

Open
wants to merge 2 commits into
base: release-8.1
Choose a base branch
from
Open

add log to 8.1 #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd6a97b
add some log
lidezhu Feb 21, 2025
aeb2b35
fix build
lidezhu Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions components/cdc/src/endpoint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,13 @@ impl fmt::Debug for Task {
.field("multi_batch", &multi.len())
.finish(),
Task::MinTs {
ref regions,
ref min_ts,
ref current_ts,
..
} => de
.field("type", &"mit_ts")
.field("type", &"min_ts")
.field("regions", &regions)
.field("current_ts", current_ts)
.field("min_ts", min_ts)
.finish(),
Expand Down Expand Up @@ -1025,6 +1027,12 @@ impl<T: 'static + CdcHandle<E>, E: KvEngine, S: StoreRegionMeta> Endpoint<T, E,
self.resolved_region_count = resolved_regions.heap.len();
self.unresolved_region_count = total_region_count - self.resolved_region_count;

debug!(
"endpoint on_min_ts";
"resolved_region_count" => self.resolved_region_count,
"unresolved_region_count" => self.unresolved_region_count,
);

// Separate broadcasting outlier regions and normal regions,
// so 1) downstreams know where they should send resolve lock requests,
// and 2) resolved ts of normal regions does not fallback.
Expand All @@ -1044,16 +1052,23 @@ impl<T: 'static + CdcHandle<E>, E: KvEngine, S: StoreRegionMeta> Endpoint<T, E,
let mut resolved_ts = ResolvedTs::default();
resolved_ts.ts = ts;
resolved_ts.request_id = request_id;
*resolved_ts.mut_regions() = regions;
*resolved_ts.mut_regions() = regions.clone();

let force_send = false;
match conn
.get_sink()
.unbounded_send(CdcEvent::ResolvedTs(resolved_ts), force_send)
{
Ok(_) => (),
Ok(_) => {
for region in regions {
info!("cdc send event succeed";
"conn_id" => ?conn.get_id(),
"downstream" => ?conn.get_peer(),
"region_id" => ?region);
}
},
Err(SendError::Disconnected) => {
debug!("cdc send event failed, disconnected";
info!("cdc send event failed, disconnected";
"conn_id" => ?conn.get_id(), "downstream" => ?conn.get_peer());
}
Err(SendError::Full) | Err(SendError::Congested) => {
Expand Down