Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aave.srv getting data by parentHash instead of <blockNumber = 1> #517

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: aave.srv getting data by parentHash instead of <blockNumber = 1> #517

merged 1 commit into from
Apr 9, 2024

Conversation

sergeyWh1te
Copy link
Contributor

Part of:
#513

@sergeyWh1te sergeyWh1te requested a review from TheDZhon April 8, 2024 12:01
@sergeyWh1te sergeyWh1te requested a review from a team as a code owner April 8, 2024 12:01
@sergeyWh1te sergeyWh1te mentioned this pull request Apr 8, 2024
Open
@sergeyWh1te sergeyWh1te force-pushed the fix-eth-fin-parent-hash branch 2 times, most recently from 35b6e84 to 1fb71a9 Compare April 8, 2024 15:00
@sergeyWh1te sergeyWh1te force-pushed the fix-eth-fin-parent-hash branch from 1fb71a9 to 48bdab6 Compare April 8, 2024 15:17
TheDZhon
TheDZhon requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot, I'm not sure about the blockTag field here 🤔

ethereum-financial/src/clients/eth_provider.ts Show resolved Hide resolved
ethereum-financial/src/clients/eth_provider.ts Show resolved Hide resolved
ethereum-financial/src/services/aave/Aave.srv.ts Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergeyWh1te sergeyWh1te merged commit 8b2cce5 into main Apr 9, 2024
5 checks passed
@sergeyWh1te sergeyWh1te deleted the fix-eth-fin-parent-hash branch April 9, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyWh1te @TheDZhon