Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stVaults #874

Draft
wants to merge 786 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
786 commits
Select commit Hold shift + click to select a range
9099c27
fix: comments and formatting
folkyatina Dec 24, 2024
b3e53b5
feat(Delegation): add comments
failingtwice Dec 24, 2024
dbabb36
test(integration): update for new delegation
failingtwice Dec 24, 2024
a936b19
fix: wrong checks in external share limit
folkyatina Dec 24, 2024
b2cc291
test: remove only
failingtwice Dec 24, 2024
e4f8595
Merge branch 'feat-immutable-operator-in-vault' into feat/vaults-sugg…
tamtamchik Dec 24, 2024
2168c79
Merge pull request #893 from lidofinance/feat/vaults-suggestions
tamtamchik Dec 24, 2024
b9ffdf6
Merge pull request #897 from lidofinance/feat-immutable-operator-in-v…
tamtamchik Dec 24, 2024
a9154a7
chore: fix slither
tamtamchik Dec 24, 2024
ab1db80
Merge remote-tracking branch 'origin/master' into feat/vaults
tamtamchik Dec 25, 2024
eafd3bc
chore: deploy devnet 2
tamtamchik Dec 25, 2024
b6156ad
feat: dashboard token recovery
Jeday Dec 26, 2024
978ff1e
Merge pull request #907 from lidofinance/feat/vaults-devnet-2
tamtamchik Dec 27, 2024
df8400f
chore: ignore only contracts in prettier
tamtamchik Dec 30, 2024
5904609
fix: get rig of double division on shares to eth conversion
folkyatina Jan 2, 2025
4e18178
feat: make VaultHub pausable
folkyatina Jan 3, 2025
a48c18a
chore: some solhint fixes
folkyatina Jan 3, 2025
b242670
chore: fix some comments and imports
folkyatina Jan 3, 2025
9822b47
chore: comments and naming
folkyatina Jan 7, 2025
a36d64b
chore: fix dependency
folkyatina Jan 7, 2025
46d1211
chore: update lockfile
folkyatina Jan 7, 2025
6ed8363
test: tests for VaultHub pausability
folkyatina Jan 8, 2025
8efb94e
chore: better comments
folkyatina Jan 8, 2025
a11d6b6
feat: add locator, update burn/mint methods, fixes, tests
DiRaiks Jan 9, 2025
29ef4ad
tests: update Delegation constructor
DiRaiks Jan 9, 2025
b5c839f
tests: add tests for burnWstETHWithPermit
DiRaiks Jan 9, 2025
65ef7d5
chore: update devnet json
tamtamchik Jan 9, 2025
6bb65b2
feat: fix tests
loga4 Jan 9, 2025
2250aa6
test: add accounting and sanity checker deployment
vp4242 Dec 30, 2024
266a990
feat: proper Accounting initialization
vp4242 Dec 30, 2024
20e62c7
test: add PostTokenRebaseReceiver
vp4242 Dec 30, 2024
595eab2
test: fix imports
vp4242 Dec 30, 2024
03733b3
fix: linter
tamtamchik Jan 3, 2025
8dd7534
chore: fix husky setup
tamtamchik Jan 3, 2025
432aab2
feat: impersonate caller instead of locator update
vp4242 Jan 8, 2025
df01272
chore: add import
vp4242 Jan 8, 2025
6ddda8a
test: add withdrawal queue related tests
vp4242 Jan 9, 2025
c17ab6c
test: add more
vp4242 Jan 9, 2025
e9afa5d
test: fix mocks
vp4242 Jan 10, 2025
050bd27
test: enable all relevant tests
vp4242 Jan 10, 2025
d456680
chore: split tests according to contracts
vp4242 Jan 10, 2025
4b16505
fix: add nft recovery
Jeday Jan 10, 2025
41f6125
fix(docs): dashboard comment
Jeday Jan 10, 2025
ae59476
Merge branch 'feat/vaults' of github.com:lidofinance/core into feat/d…
Jeday Jan 10, 2025
de3d3b9
fix: update naming for burn/mint
Jeday Jan 10, 2025
3261a8c
fix(test): check allowance in dashboard
Jeday Jan 10, 2025
c228afd
fix(test): remove extra await
Jeday Jan 10, 2025
c6cc70f
fix(test): dashboard address reuse
Jeday Jan 10, 2025
739a60d
test: dashboard valuation and recieve
Jeday Jan 10, 2025
839b726
fix: happy path integration test and linters
tamtamchik Jan 10, 2025
99f7d9a
fix: tests
tamtamchik Jan 10, 2025
186e266
test: update tests for dashboard
tamtamchik Jan 10, 2025
0aea721
fix: reduce dashboard._burn gas
Jeday Jan 13, 2025
c4e7ceb
chore: simplify burnWstETH
tamtamchik Jan 13, 2025
eac8eb9
Merge branch 'develop' into feat/vaults
tamtamchik Jan 13, 2025
62710b0
Merge branch 'feat/dashboard-ux-updates' of github.com:lidofinance/co…
Jeday Jan 14, 2025
95b11fb
fix: use eth address convention
Jeday Jan 14, 2025
c191ac2
fix(StakingVault): rename operator -> nodeOperator
failingtwice Jan 14, 2025
5ebc00f
feat: remove factory checks
loga4 Jan 14, 2025
e54e2d0
Merge remote-tracking branch 'origin/feat/factory-upgrade' into feat/…
loga4 Jan 14, 2025
29159ac
feat: remove getBeacon()
loga4 Jan 14, 2025
0ace794
feat: remove comments
loga4 Jan 14, 2025
b5ce3a4
fix: to lowercase address
Jeday Jan 14, 2025
fe87ca3
fix: revert to checksum
Jeday Jan 14, 2025
50259ec
Merge pull request #908 from lidofinance/feat/vaults-dashboard-recovery
tamtamchik Jan 14, 2025
4aa0eb6
feat: add immutable args for Clones
loga4 Jan 14, 2025
6265561
feat: add immutable args for Clones
loga4 Jan 14, 2025
a3ae0b1
chore: remove unused mock
vp4242 Jan 14, 2025
2ad9d7c
chore: remove unused mock
vp4242 Jan 15, 2025
661af1f
test: remove accounting and locator from lido test
vp4242 Jan 15, 2025
fac1f9d
feat(vaults): mint/burn steth
Jeday Jan 15, 2025
41c1c7e
feat: pausable beacon deposits
tamtamchik Jan 15, 2025
e1511f7
fix: rename roles
failingtwice Jan 15, 2025
07b6249
feat: admin sets curator fee
failingtwice Jan 15, 2025
4f7a96a
fix: typo
failingtwice Jan 15, 2025
1af937a
Merge branch 'develop' into feat/vaults
tamtamchik Jan 15, 2025
2c50382
Merge branch 'feat/vaults' into feat/vaults-pausable-deposits
tamtamchik Jan 15, 2025
710ccac
docs: burn shares permit comment
Jeday Jan 15, 2025
36fbd1c
test: add mocks
vp4242 Jan 15, 2025
212161e
test: remove cohesion of lido and accounting
vp4242 Jan 15, 2025
43482eb
test: port some tests back to Lido contact tests
vp4242 Jan 15, 2025
5ee67ae
chore: added a comment about denominator greater than zero
folkyatina Jan 15, 2025
50a3eeb
Merge pull request #913 from lidofinance/precision-loss-2
folkyatina Jan 15, 2025
6639080
test(StakingVault): fix test after renaming
failingtwice Jan 16, 2025
520f9ba
docs: better comments
folkyatina Jan 16, 2025
50d8b6e
Merge pull request #914 from lidofinance/pausable-vault-hub
folkyatina Jan 16, 2025
e93484a
test(Delegation): fix test afte renaming
failingtwice Jan 16, 2025
4f99e58
test(Dashboard): fix test after renaming
failingtwice Jan 16, 2025
fd1c88b
fix(VaultFactory): fix after renaming
failingtwice Jan 16, 2025
3588e47
test(VaultHappyPath): fix after renaming
failingtwice Jan 16, 2025
5d3b2ff
test: fix mint accounting tests
vp4242 Jan 16, 2025
e10f796
test: fix import
vp4242 Jan 16, 2025
77d8739
fix: use round up
Jeday Jan 16, 2025
8cf3484
Merge pull request #923 from lidofinance/another-round-of-renamings
failingtwice Jan 16, 2025
48bccda
chore: fixes after review
tamtamchik Jan 16, 2025
862360c
Merge branch 'feat/vaults' into feat/vaults-pausable-deposits
tamtamchik Jan 16, 2025
ffcb109
fix: tests
tamtamchik Jan 16, 2025
0903095
feat: fix burnWsteth
Jeday Jan 16, 2025
5300444
feat(test): mint wsteth wei tests
Jeday Jan 16, 2025
f52348a
feat: remove local OZ-5.2.0
loga4 Jan 16, 2025
b7fdc32
test: remove unused mocks
vp4242 Jan 16, 2025
633d6ba
test: rename mock event
vp4242 Jan 16, 2025
edb0215
test: move mock to newer solidity version to allow custom errors
vp4242 Jan 16, 2025
88168ef
test: add custom errors check
vp4242 Jan 16, 2025
3af7f9b
test: check actual reporting
vp4242 Jan 16, 2025
ade6c03
test: fix the reporting test case
vp4242 Jan 16, 2025
275f2ac
fix: minor fixes after review
folkyatina Jan 16, 2025
55ea316
chore: silence solc warnings
folkyatina Jan 16, 2025
17b8a80
test: fix typo
folkyatina Jan 16, 2025
765a205
chore: duplicate logic into dashboard
tamtamchik Jan 16, 2025
4d3f84d
feat: add proxy bytecode verification, remove implementation verifica…
loga4 Jan 16, 2025
73b10cc
feat: sync feat/vaults
loga4 Jan 16, 2025
455c189
feat: sync feat/vaults
loga4 Jan 16, 2025
cfef66c
feat(StakingVault): simplify deposit process
failingtwice Jan 17, 2025
f24c48e
test: variable wei/shareRate burnWsteth test
Jeday Jan 17, 2025
90f64d4
fix: burner event order
Jeday Jan 17, 2025
5a907fc
docs: comment
Jeday Jan 17, 2025
b529f7b
Merge branch 'feat/vaults' of github.com:lidofinance/core into feat/d…
Jeday Jan 17, 2025
5215e35
docs: add notice
Jeday Jan 17, 2025
5bca471
chore: solhint cleanup
folkyatina Jan 19, 2025
28139c8
fix: revert ETHDistributed event abi
folkyatina Jan 19, 2025
0deab08
test: fix ETHDistributed checks
folkyatina Jan 19, 2025
444506a
feat: change OZ version v5.0.2 -> v5.2
loga4 Jan 20, 2025
63e0507
Update contracts/0.8.25/vaults/Dashboard.sol
tamtamchik Jan 20, 2025
da66162
fix: deposit data root calculation
failingtwice Jan 21, 2025
d4a234f
feat(StakingVault): update year
failingtwice Jan 21, 2025
33eb2d7
fix: linting
failingtwice Jan 21, 2025
cf4ad78
Merge pull request #912 from lidofinance/feat/fix-accounting-tests-va…
folkyatina Jan 21, 2025
deb0e47
chore: bump coverage threshold
tamtamchik Jan 21, 2025
26c0a2f
fix: review fixes
loga4 Jan 21, 2025
3019051
Merge pull request #920 from lidofinance/feat/factory-upgrade-immutable
loga4 Jan 21, 2025
292920a
Merge pull request #901 from lidofinance/feat/factory-upgrade
loga4 Jan 21, 2025
8fa9089
feat(StakingVault): include total deposit amount in the event
failingtwice Jan 22, 2025
42fd97b
feat(StakingVault): deposit data root util
failingtwice Jan 22, 2025
71e93b2
feat(StakingVault): deposit data root util
failingtwice Jan 22, 2025
95b85fc
merge
failingtwice Jan 22, 2025
04d69df
Merge branch 'feat/vaults' of https://github.com/lidofinance/core int…
failingtwice Jan 22, 2025
b2e6660
fix(IDepositContract): update year
failingtwice Jan 22, 2025
142ea4d
fix: formatting
failingtwice Jan 22, 2025
b12a322
test: add sample source
failingtwice Jan 22, 2025
f78235c
Merge branch 'feat/vaults' of github.com:lidofinance/core into feat/d…
Jeday Jan 22, 2025
bea9a49
test: fix oz version
Jeday Jan 22, 2025
e62e76e
Merge pull request #925 from lidofinance/deposit-logistics
failingtwice Jan 22, 2025
7ba6837
Merge branch 'feat/vaults' into feat/vaults-pausable-deposits
tamtamchik Jan 22, 2025
0908dc7
fix: tests after merge with main branch
tamtamchik Jan 22, 2025
dce00fb
Merge pull request #922 from lidofinance/feat/vaults-pausable-deposits
tamtamchik Jan 22, 2025
616a0f8
fix: use safeERC20
Jeday Jan 23, 2025
2b871fb
Merge branch 'feat/vaults' of github.com:lidofinance/core into feat/d…
Jeday Jan 23, 2025
c9c7f74
test: whitespace
Jeday Jan 23, 2025
c8e9df5
feat(AccessControlVoteable): extract into a separate contract
failingtwice Jan 23, 2025
08f54b8
feat(AccessControlVoteable): use in Dashboard/Delegation
failingtwice Jan 23, 2025
e470a89
fix: fund/withdraw naming
Jeday Jan 23, 2025
6f5703c
feat: granular permissions
failingtwice Jan 23, 2025
ef1399e
feat(Dashboard): add batch role methods
failingtwice Jan 23, 2025
6f96bf1
feat: extract granular permissions to a separate contract
failingtwice Jan 27, 2025
d51f73b
feat: msg.sender-agnostic deploy
failingtwice Jan 27, 2025
cb14793
feat: use structs for mass-grant/revoke roles
failingtwice Jan 27, 2025
ea7b30d
fix: transfer ownership naming
failingtwice Jan 27, 2025
ee0f423
feat(VaultFactory): full config
failingtwice Jan 27, 2025
647c938
fix(IZeroArgument): natspec
failingtwice Jan 27, 2025
0af02b2
fix(Dashboard): clean up modifiers
failingtwice Jan 27, 2025
5db88eb
fix(Delegation): natspec
failingtwice Jan 27, 2025
902af5f
chore: update dependencies
tamtamchik Jan 27, 2025
29b8b50
ci: use hh 2.22.18
tamtamchik Jan 27, 2025
8639d1b
feat(Permissions): reorganize inheritance
failingtwice Jan 27, 2025
f961c24
refactor: add mass-role control to dashboard
failingtwice Jan 27, 2025
28dff49
fix: comment format
failingtwice Jan 27, 2025
82ea3c6
fix: comment format
failingtwice Jan 27, 2025
fcd7afe
Merge branch 'feat/vaults' of https://github.com/lidofinance/core int…
failingtwice Jan 27, 2025
0a090ba
feat(Permissions): pause/resume deposits
failingtwice Jan 27, 2025
eba5464
fix: argnames and vote lifetime
failingtwice Jan 27, 2025
faf4cc0
Merge pull request #931 from lidofinance/feat/updates
tamtamchik Jan 27, 2025
222a580
fix(Dashboard): remove super to allow internal overriding in parent
failingtwice Jan 28, 2025
fb230c6
fix: bypass withdraw role check for fee claim
failingtwice Jan 28, 2025
339601a
test: skip dashboard tests
failingtwice Jan 28, 2025
7a0df1e
test: fix delegation test after permissions rework
failingtwice Jan 28, 2025
58bf4fa
test: fix after permissions rework
failingtwice Jan 28, 2025
6f8bd86
test: fix vault happy path
failingtwice Jan 28, 2025
199d078
fix: types
failingtwice Jan 28, 2025
334155a
Merge pull request #929 from lidofinance/feat/granular-permissions
failingtwice Jan 28, 2025
0c94a5e
Merge branch 'feat/vaults' into accounting-review-fixes
tamtamchik Jan 28, 2025
00037f4
fix: tests
tamtamchik Jan 28, 2025
3e9489d
fix: linters
tamtamchik Jan 28, 2025
50419bc
Merge pull request #924 from lidofinance/accounting-review-fixes
tamtamchik Jan 28, 2025
4ff312b
Merge branch 'feat/vaults' of github.com:lidofinance/core into feat/d…
Jeday Jan 28, 2025
34d4519
fix: dashboard tests
Jeday Jan 28, 2025
b7e5536
fix: remove onlyRole
Jeday Jan 29, 2025
0c2c170
fix: unused imports & naming
Jeday Jan 29, 2025
067f38b
test: fix delegation test
Jeday Jan 29, 2025
b3bdc1f
Merge pull request #915 from lidofinance/feat/dashboard-ux-updates
Jeday Jan 29, 2025
1387854
feat: deploy devnet 3
tamtamchik Jan 29, 2025
0ceebd6
chore: add BeaconProxy to verification
tamtamchik Jan 29, 2025
09621f5
chore: move outdated deployments to archive
tamtamchik Jan 29, 2025
31bf140
Merge pull request #934 from lidofinance/feat/vaults-devnet-3
tamtamchik Jan 29, 2025
23a4fa9
fix: remove unsafeWithdraw
failingtwice Jan 30, 2025
19755bb
feat: move mass-role management to permissions
failingtwice Jan 30, 2025
fdb7a08
fix: rename optional fund modifier
failingtwice Jan 30, 2025
0ab9aa7
feat: hooray! renaming!
failingtwice Jan 31, 2025
8c43b13
feat: update role ids
failingtwice Jan 31, 2025
3403a81
fix(Permissions): update role ids
failingtwice Jan 31, 2025
18f184b
refactor(Permissions): hide assembly in an internal func
failingtwice Jan 31, 2025
9839009
feat: log default admin in initialized event
failingtwice Jan 31, 2025
adeb088
feat: pass confirm lifetime as init param
failingtwice Jan 31, 2025
34c2e62
feat: don't use msg.sender in init
failingtwice Jan 31, 2025
038e722
fix: modifier order
failingtwice Feb 3, 2025
b16075c
test: permissions setup
failingtwice Feb 3, 2025
3e82d3a
feat: store expiry instead of cast timestamp
failingtwice Feb 3, 2025
62a8caa
fix: use raw data for mapping key
failingtwice Feb 3, 2025
b9dc9c3
fix: revert if roles array empty
failingtwice Feb 3, 2025
0bfc88a
feat: override withdrawableEther in Delegation contract
DiRaiks Feb 10, 2025
fce5c97
fix: rename access control confirmable
failingtwice Feb 11, 2025
7e1f108
fix: tailing renaming
failingtwice Feb 11, 2025
b3bc8d7
Merge branch 'master' into feat/vaults
tamtamchik Feb 11, 2025
2688545
feat: add more role granularity
failingtwice Feb 12, 2025
927703f
feat: add getter for timestamp
failingtwice Feb 12, 2025
7b38228
fix: add a behavior comment
failingtwice Feb 12, 2025
214af41
fix: shorten name to fit the line
failingtwice Feb 12, 2025
6bb0fcf
feat: add comment
failingtwice Feb 12, 2025
fae8443
feat: add behavior comment
failingtwice Feb 12, 2025
869c605
Merge pull request #938 from lidofinance/feat/delegation_views
TheDZhon Feb 12, 2025
f627871
feat(Permissions): cover with comments
failingtwice Feb 12, 2025
5d90549
fix: update some naming
failingtwice Feb 12, 2025
9e6ad21
fix(VaultFactory): role names
failingtwice Feb 12, 2025
48ddb15
fix(ACLConfirmable): log expiry timestamp
failingtwice Feb 12, 2025
d5b5f0b
fix(tests): update delegation tests
failingtwice Feb 12, 2025
a286dc1
fix: prevent 0 lifetime situations
failingtwice Feb 13, 2025
0c2f6ab
feat: add lifetime bounds
failingtwice Feb 13, 2025
a09e964
test(ACLConfirmable): full coverage
failingtwice Feb 13, 2025
fdfe70b
test(Permissions): full coverage
failingtwice Feb 14, 2025
de8c979
fix(tests): update dashboard tests
failingtwice Feb 14, 2025
6963f65
fix(Dashboard): update comments
failingtwice Feb 14, 2025
82818b3
Merge branch 'feat/vaults' of https://github.com/lidofinance/core int…
failingtwice Feb 14, 2025
e2b9b3b
fix(Delegation): update tests
failingtwice Feb 14, 2025
4c4002a
test(Factory): remove curator check
failingtwice Feb 14, 2025
48d80c0
feat: revert if node operator is zero address on init
failingtwice Feb 14, 2025
9bc4f77
fix: minor fixes
failingtwice Feb 17, 2025
a494579
fix: update comments
failingtwice Feb 17, 2025
2140ac0
Merge branch 'develop' into feat/vaults
tamtamchik Feb 18, 2025
5d853cd
fix(test): vaults happy path
tamtamchik Feb 18, 2025
fd9b0b7
fix(test): vebo tests
tamtamchik Feb 18, 2025
74e8478
fix: comment more details
failingtwice Feb 19, 2025
515504f
fix: remove unused role
failingtwice Feb 19, 2025
0751a1f
feat(VaultFactory): pass role members array
failingtwice Feb 19, 2025
5c83c35
Merge branch 'feat/vaults' of https://github.com/lidofinance/core int…
failingtwice Feb 19, 2025
4c7ff7a
fix: update comment
failingtwice Feb 19, 2025
a09aa97
feat: rename 🧠
failingtwice Feb 19, 2025
6ed77cd
Merge pull request #935 from lidofinance/permissions-polish
failingtwice Feb 19, 2025
2a004a1
fix(VaultHub): rename mint/burn
failingtwice Feb 19, 2025
bd81a22
Merge pull request #953 from lidofinance/RENAME#384
tamtamchik Feb 19, 2025
80d2e49
Merge branch 'develop' into feat/vaults
tamtamchik Feb 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .env.example
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# RPC URL for a locally running node (Ganache, Anvil, Hardhat Network, etc.), used for scratch deployment and tests
LOCAL_RPC_URL=http://localhost:8555

LOCAL_LOCATOR_ADDRESS=
LOCAL_AGENT_ADDRESS=
LOCAL_VOTING_ADDRESS=
Expand All @@ -25,11 +24,6 @@ LOCAL_WITHDRAWAL_VAULT_ADDRESS=

# RPC URL for a separate, non Hardhat Network node (Anvil, Infura, Alchemy, etc.)
MAINNET_RPC_URL=http://localhost:8545

# RPC URL for Hardhat Network forking, required for running tests on mainnet fork with tracing (Infura, Alchemy, etc.)
# https://hardhat.org/hardhat-network/docs/guides/forking-other-networks#forking-other-networks
HARDHAT_FORKING_URL=

# https://docs.lido.fi/deployed-contracts
MAINNET_LOCATOR_ADDRESS=0xC1d0b3DE6792Bf6b4b37EccdcC24e45978Cfd2Eb
MAINNET_AGENT_ADDRESS=0x3e40D73EB977Dc6a537aF587D48316feE66E9C8c
Expand All @@ -53,6 +47,13 @@ MAINNET_VALIDATORS_EXIT_BUS_ORACLE_ADDRESS=
MAINNET_WITHDRAWAL_QUEUE_ADDRESS=
MAINNET_WITHDRAWAL_VAULT_ADDRESS=

HOLESKY_RPC_URL=
SEPOLIA_RPC_URL=

# RPC URL for Hardhat Network forking, required for running tests on mainnet fork with tracing (Infura, Alchemy, etc.)
# https://hardhat.org/hardhat-network/docs/guides/forking-other-networks#forking-other-networks
HARDHAT_FORKING_URL=

# Scratch deployment via hardhat variables
DEPLOYER=0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
GENESIS_TIME=1639659600
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ jobs:
with:
path: ./coverage/cobertura-coverage.xml
publish: true
threshold: 95
# TODO: restore to 95% before release
threshold: 80
diff: true
diff-branch: master
diff-storage: _core_coverage_reports
Expand Down
59 changes: 29 additions & 30 deletions .github/workflows/tests-integration-mainnet.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe restore later

Original file line number Diff line number Diff line change
@@ -1,31 +1,30 @@
name: Integration Tests

on: [push]

jobs:
test_hardhat_integration_fork:
name: Hardhat / Mainnet
runs-on: ubuntu-latest
timeout-minutes: 120

services:
hardhat-node:
image: ghcr.io/lidofinance/hardhat-node:2.22.12
ports:
- 8545:8545
env:
ETH_RPC_URL: "${{ secrets.ETH_RPC_URL }}"

steps:
- uses: actions/checkout@v4

- name: Common setup
uses: ./.github/workflows/setup

- name: Set env
run: cp .env.example .env

- name: Run integration tests
run: yarn test:integration:fork:mainnet
env:
LOG_LEVEL: debug
#on: [push]
#
#jobs:
# test_hardhat_integration_fork:
# name: Hardhat / Mainnet
# runs-on: ubuntu-latest
# timeout-minutes: 120
#
# services:
# hardhat-node:
# image: ghcr.io/lidofinance/hardhat-node:2.22.17
# ports:
# - 8545:8545
# env:
# ETH_RPC_URL: "${{ secrets.ETH_RPC_URL }}"
#
# steps:
# - uses: actions/checkout@v4
#
# - name: Common setup
# uses: ./.github/workflows/setup
#
# - name: Set env
# run: cp .env.example .env
#
# - name: Run integration tests
# run: yarn test:integration:fork:mainnet
# env:
# LOG_LEVEL: debug
4 changes: 2 additions & 2 deletions .github/workflows/tests-integration-scratch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:

services:
hardhat-node:
image: ghcr.io/lidofinance/hardhat-node:2.22.12-scratch
image: ghcr.io/lidofinance/hardhat-node:2.22.17-scratch
ports:
- 8555:8545

Expand All @@ -33,7 +33,7 @@ jobs:
GAS_PRIORITY_FEE: 1
GAS_MAX_FEE: 100
NETWORK_STATE_FILE: "deployed-local.json"
NETWORK_STATE_DEFAULTS_FILE: "scripts/scratch/deployed-testnet-defaults.json"
NETWORK_STATE_DEFAULTS_FILE: "scripts/defaults/testnet-defaults.json"

- name: Finalize scratch deployment
run: yarn hardhat --network local run --no-compile scripts/utils/mine.ts
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.idea/
.yarn/
.vscode/

node_modules/
coverage/
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.12
22.11
1 change: 1 addition & 0 deletions .solcover.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ module.exports = {
// Skip contracts that are tested by Foundry tests
"common/lib", // 100% covered by test/common/*.t.sol
"0.8.9/lib/UnstructuredStorage.sol", // 100% covered by test/0.8.9/unstructuredStorage.t.sol
"openzeppelin",
],
};
6 changes: 4 additions & 2 deletions .solhintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
contracts/Migrations.sol
contracts/0.6.11/deposit_contract.sol
contracts/openzeppelin/
contracts/0.6.11/deposit_contract.sol
contracts/0.6.12/WstETH.sol
contracts/0.8.4/WithdrawalsManagerProxy.sol
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ the [Lido Research Forum](https://research.lido.fi/).

### Requirements

- [Node.js](https://nodejs.org/en) version 20 (LTS) with `corepack` enabled
- [Node.js](https://nodejs.org/en) version 22 (LTS) with `corepack` enabled
- [Yarn](https://yarnpkg.com/) installed via corepack (see below)
- [Foundry](https://book.getfoundry.sh/) latest available version

Expand Down
Loading
Loading