feat: [draft] vaults validators triggerable exits #933
+2,578
−408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add role ADD_FULL_WITHDRAWAL_REQUEST_ROLE for full withdrawal requests.
…hdrawal-credentials
Access pubkeys and amounts directly instead of copying them to memory.
pass pubkeys as array of bytes
…o feat/waults-triggerable-exits # Conflicts: # scripts/scratch/steps/0120-initialize-non-aragon-contracts.ts
# Conflicts: # contracts/0.8.25/vaults/Dashboard.sol # test/integration/vaults-happy-path.integration.ts
…le-exits # Conflicts: # contracts/0.8.9/WithdrawalVault.sol # contracts/common/lib/TriggerableWithdrawals.sol
…le-exits # Conflicts: # contracts/common/lib/TriggerableWithdrawals.sol # test/common/lib/triggerableWithdrawals/triggerableWithdrawals.test.ts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+160
to
+188
| function addFullWithdrawalRequests( | ||
| bytes calldata pubkeys | ||
| ) external payable onlyRole(ADD_FULL_WITHDRAWAL_REQUEST_ROLE) { | ||
| uint256 prevBalance = address(this).balance - msg.value; | ||
|
|
||
| uint256 minFeePerRequest = TriggerableWithdrawals.getWithdrawalRequestFee(); | ||
| uint256 totalFee = (pubkeys.length / TriggerableWithdrawals.PUBLIC_KEY_LENGTH) * minFeePerRequest; | ||
|
|
||
| if (totalFee > msg.value) { | ||
| revert InsufficientTriggerableWithdrawalFee( | ||
| msg.value, | ||
| totalFee, | ||
| pubkeys.length / TriggerableWithdrawals.PUBLIC_KEY_LENGTH | ||
| ); | ||
| } | ||
|
|
||
| TriggerableWithdrawals.addFullWithdrawalRequests(pubkeys, minFeePerRequest); | ||
|
|
||
| uint256 refund = msg.value - totalFee; | ||
| if (refund > 0) { | ||
| (bool success, ) = msg.sender.call{value: refund}(""); | ||
|
|
||
| if (!success) { | ||
| revert TriggerableWithdrawalRefundFailed(); | ||
| } | ||
| } | ||
|
|
||
| assert(address(this).balance == prevBalance); | ||
| } |
Check warning
Code scanning / Slither
Divide before multiply Medium
Comment on lines
+160
to
+188
| function addFullWithdrawalRequests( | ||
| bytes calldata pubkeys | ||
| ) external payable onlyRole(ADD_FULL_WITHDRAWAL_REQUEST_ROLE) { | ||
| uint256 prevBalance = address(this).balance - msg.value; | ||
|
|
||
| uint256 minFeePerRequest = TriggerableWithdrawals.getWithdrawalRequestFee(); | ||
| uint256 totalFee = (pubkeys.length / TriggerableWithdrawals.PUBLIC_KEY_LENGTH) * minFeePerRequest; | ||
|
|
||
| if (totalFee > msg.value) { | ||
| revert InsufficientTriggerableWithdrawalFee( | ||
| msg.value, | ||
| totalFee, | ||
| pubkeys.length / TriggerableWithdrawals.PUBLIC_KEY_LENGTH | ||
| ); | ||
| } | ||
|
|
||
| TriggerableWithdrawals.addFullWithdrawalRequests(pubkeys, minFeePerRequest); | ||
|
|
||
| uint256 refund = msg.value - totalFee; | ||
| if (refund > 0) { | ||
| (bool success, ) = msg.sender.call{value: refund}(""); | ||
|
|
||
| if (!success) { | ||
| revert TriggerableWithdrawalRefundFailed(); | ||
| } | ||
| } | ||
|
|
||
| assert(address(this).balance == prevBalance); | ||
| } |
Check warning
Code scanning / Slither
Dangerous strict equalities Medium
tamtamchik
force-pushed
the
feat/vaults-triggerable-exits
branch
from
41728a7 to
a30cd67
Compare
Comment on lines
+111
to
+120
| function _getAndValidateExitFees(bytes calldata _pubkeys) private view returns (uint256 feePerRequest, uint256 totalFee) { | ||
| feePerRequest = TriggerableWithdrawals.getWithdrawalRequestFee(); | ||
| totalFee = _pubkeys.length / TriggerableWithdrawals.PUBLIC_KEY_LENGTH * feePerRequest; | ||
|
|
||
| if (msg.value < totalFee) { | ||
| revert InsufficientExitFee(msg.value, totalFee); | ||
| } | ||
|
|
||
| return (feePerRequest, totalFee); | ||
| } |
Check warning
Code scanning / Slither
Divide before multiply Medium
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: a30cd67 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tamtamchik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add triggerable exits for vaults