Skip to content

Commit

Permalink
Fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sandstone-ag committed Oct 16, 2024
1 parent 82508d4 commit 306e8a5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
1 change: 0 additions & 1 deletion scripts/deploy/DeployBase.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ abstract contract DeployBase is Script {
DeployConfig internal config;
LidoContracts internal lidoAddresses;
address private deployer;
uint256 private pk;

function run() external {
if (lidoAddresses.chainId != block.chainid) {
Expand Down
8 changes: 3 additions & 5 deletions scripts/deploy/DeployVerification.sol
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ pragma solidity 0.8.26;

import {Timestamps} from "contracts/types/Timestamp.sol";
import {Durations} from "contracts/types/Duration.sol";
import {PercentD16} from "contracts/types/PercentD16.sol";
import {Executor} from "contracts/Executor.sol";
import {IEmergencyProtectedTimelock} from "contracts/interfaces/IEmergencyProtectedTimelock.sol";
import {EmergencyProtectedTimelock} from "contracts/EmergencyProtectedTimelock.sol";
Expand Down Expand Up @@ -196,13 +195,11 @@ library DeployVerification {

DualGovernanceConfig.Context memory dgConfig = dg.getConfigProvider().getDualGovernanceConfig();
require(
PercentD16.unwrap(dgConfig.firstSealRageQuitSupport)
== PercentD16.unwrap(dgDeployConfig.FIRST_SEAL_RAGE_QUIT_SUPPORT),
dgConfig.firstSealRageQuitSupport == dgDeployConfig.FIRST_SEAL_RAGE_QUIT_SUPPORT,
"Incorrect parameter FIRST_SEAL_RAGE_QUIT_SUPPORT"
);
require(
PercentD16.unwrap(dgConfig.secondSealRageQuitSupport)
== PercentD16.unwrap(dgDeployConfig.SECOND_SEAL_RAGE_QUIT_SUPPORT),
dgConfig.secondSealRageQuitSupport == dgDeployConfig.SECOND_SEAL_RAGE_QUIT_SUPPORT,
"Incorrect parameter SECOND_SEAL_RAGE_QUIT_SUPPORT"
);
require(
Expand Down Expand Up @@ -250,6 +247,7 @@ library DeployVerification {
require(dg.getEffectiveState() == State.Normal, "Incorrect DualGovernance effective state");
require(dg.getProposers().length == 1, "Incorrect amount of proposers");
require(dg.isProposer(address(lidoAddresses.voting)) == true, "Lido voting is not set as a proposers[0]");
require(dg.isExecutor(res.adminExecutor) == true, "adminExecutor is not set as a proposers[0].executor");

IDualGovernance.StateDetails memory stateDetails = dg.getStateDetails();
require(stateDetails.effectiveState == State.Normal, "Incorrect DualGovernance effectiveState");
Expand Down

0 comments on commit 306e8a5

Please sign in to comment.