Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending DualGovernance state #127

Merged
merged 20 commits into from
Sep 27, 2024
Merged

Pending DualGovernance state #127

merged 20 commits into from
Sep 27, 2024

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Sep 11, 2024

  • Rename method getState() to getPersistedState().
  • Introduce method getEffectiveState(), which returns the state that DualGovernance would transition to upon calling the DualGovernance.activateNextState() method.
  • Include information about both persisted and effective states in the StateDetails struct.
  • Introduce a new getter DualGovernance.canCancelAllPendingProposals().
  • Use effective state in the following getters: canSubmitProposal(), canScheduleProposal(), getTiebreakerDetails(), canCancelAllPendingProposals().
  • Move the configProvider field into the DualGovernanceStateMachine.Context struct.
  • Call activateNextState() as the first action in the DualGovernance.resealSealable() method.
  • Call activateNextState() as the first and last action in the Escrow.markUnstETHFinalized() method.
  • Call DualGovernance.activateNextState() as the first action in the Escrow.requestWithdrawals() method.
  • Update the specification with the newly introduced changes.
  • Fix any failed tests.
  • Add tests for all newly introduced methods.
  • Return bool flag from the cancelAllPendingProposals() method.
  • Add NatSpec comments to DualGovernance, Escrow contracts, and DualGovernanceStateMachine, DualGovernanceStateTransitions libs.

@Psirex Psirex marked this pull request as ready for review September 25, 2024 10:11
Copy link
Contributor

@bulbozaur bulbozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sandstone-ag sandstone-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Psirex Psirex merged commit 1ffa251 into develop Sep 27, 2024
2 checks passed
@bulbozaur bulbozaur deleted the feature/pending-dg-state branch September 27, 2024 09:44
@bulbozaur bulbozaur restored the feature/pending-dg-state branch October 30, 2024 10:03
@bulbozaur bulbozaur deleted the feature/pending-dg-state branch November 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants