Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit fix: Function Visibility Overly Permissive #169

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Audit fix: Function Visibility Overly Permissive #169

merged 4 commits into from
Nov 11, 2024

Conversation

bulbozaur
Copy link
Contributor

No description provided.

Psirex
Psirex requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@Psirex Psirex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the mentions of the public modifier in the plan-b and specification docs.

@Psirex
Copy link
Contributor

Psirex commented Nov 11, 2024

Also, please check that all the visibility modifiers are correct in the specification.md file.

@bulbozaur bulbozaur merged commit a428d7c into develop Nov 11, 2024
2 checks passed
@bulbozaur bulbozaur deleted the fix/functions-visibility branch November 18, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psirex Psirex Psirex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bulbozaur @Psirex