Update interfaces #178
Open
Update interfaces #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psirex
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Great work on improving the interfaces—they look much more comprehensive now! A few additional suggestions for further enhancements:
- Consider removing the
IAragonVoting.solinterface, as it appears to be used only in scripts that do not invoke any contract methods. If it is still required for scripts, thetest/utils/interfaces/IAragonAgent.solinterface could be reused instead. - Add an
executeProposal()method to theDualGovernancecontract to mirror the functionality ofEmergencyProtectedTimelock.execute()in theTimelockedGovernancecontract. Alternatively, remove theexecuteProposal()method from theTimelockedGovernancecontract if it is not strictly necessary, ensuring consistency across both contracts. - For consistency with other interfaces, consider moving the
WithdrawalRequestStatusstruct into theIWithdrawalQueueinterface.
contracts/interfaces/IEscrow.sol
Outdated
| /// @param stETHClaimedETH The total amount of ETH claimed from the stETH shares locked in the Escrow. | ||
| /// @param unstETHUnfinalizedShares The total number of shares from unstETH NFTs that have not yet been marked as finalized. | ||
| /// @param unstETHFinalizedETH The total amount of ETH claimable from unstETH NFTs that have been marked as finalized. | ||
| struct LockedAssetsTotals { |
There was a problem hiding this comment.
I propose putting these structures inside the IEscrow interface. Then, they may be used inside the Escrow contract without additional imports.
| function MAX_EMERGENCY_MODE_DURATION() external view returns (Duration); | ||
| function MAX_EMERGENCY_PROTECTION_DURATION() external view returns (Duration); | ||
|
|
||
| function setupDelays(Duration afterSubmitDelay, Duration afterScheduleDelay) external; |
There was a problem hiding this comment.
Let's move methods setupDelays(), transferExecutorOwnership(), getAfterSubmitDelay(), getAfterScheduleDelay() and setAdminExecutor() into the ITimelock.sol interface
… contracts and appropriate interfaces. Fix obsolete comments.
|
@Psirex Thank you for the comments. I've added a method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.