Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/si 1594 ledger hid connection via low speed internet #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

manneredboor
Copy link
Contributor

Description

There is an issue if the ledger packages loading takes too long (~ >5 sec): a user will see a connection error immediately after packages were loaded. That happens because of browser protection mechanism called User Activation.

Suggestion: Measure the time it took to download the Ledger packages. If it took >3s, show an additional "Connect" button in the Ledger modal instead of trying to connect right away.

Testing notes

  1. Enable "Slow 4g" throttling option
  2. Click "Ledger" connect button
  3. Huge ledger packages are starting to load, it takes >5 seconds
  4. Ledger packages are finished loading. There was an error before on this stage. Now it should show "Connect" button, which when being clicked confirms user intention for the browser.

Demo

image

@manneredboor manneredboor requested a review from a team as a code owner November 19, 2024 05:19
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 70ab6f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants