fix: upd sanity checker param

lidofinance · Feb 13, 2024 · 1f910e1 · 1f910e1
1 parent 32fc66d
commit 1f910e1
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 3 deletions.
diff --git a/scripts/vote_simple_dvt.py b/scripts/vote_simple_dvt.py
@@ -247,6 +247,32 @@ def start_vote(tx_params: Dict[str, str], silent: bool) -> bool | list[int | Tra
                 ]
             ),
         ),
+        #
+        # V. Update Sanity Checker parameters
+        #
+        (
+            "19) Grant REQUEST_BURN_SHARES_ROLE on Burner for SimpleDVT module",
+            agent_forward(
+                [
+                    encode_oz_grant_role(
+                        contract=contracts.oracle_report_sanity_checker,
+                        role_name="MAX_ACCOUNTING_EXTRA_DATA_LIST_ITEMS_COUNT_ROLE",
+                        grant_to=contracts.agent,
+                    )
+                ]
+            ),
+        ),
+        (
+            "20) Increase maxAccountingExtraDataListItemsCount sanity checker parameter from 2 to 4",
+            agent_forward(
+                [
+                    (
+                        contracts.oracle_report_sanity_checker.address,
+                        contracts.oracle_report_sanity_checker.setMaxAccountingExtraDataListItemsCount.encode_input(4),
+                    ),
+                ]
+            ),
+        ),
     )
 
     vote_items = bake_vote_items(list(vote_desc_items), list(call_script_items))

diff --git a/tests/test_simple_dvt.py b/tests/test_simple_dvt.py
@@ -62,6 +62,7 @@
 MANAGE_NODE_OPERATOR_ROLE = "0x78523850fdd761612f46e844cf5a16bda6b3151d6ae961fd7e8e7b92bfbca7f8"
 SET_NODE_OPERATOR_LIMIT_ROLE = "0x07b39e0faf2521001ae4e58cb9ffd3840a63e205d288dc9c93c3774f0d794754"
 MANAGE_SIGNING_KEYS = "0x75abc64490e17b40ea1e66691c3eb493647b24430b358bd87ec3e5127f1621ee"
+MAX_ACCOUNTING_EXTRA_DATA_LIST_ITEMS_COUNT_ROLE = "0x0cf253eb71298c92e2814969a122f66b781f9b217f8ecde5401e702beb9345f6"
 
 simple_dvt_repo_ens = "simple-dvt.lidopm.eth"
 simple_dvt_content_uri = (
@@ -110,6 +111,9 @@ def test_vote(helpers, accounts, vote_ids_from_env, stranger, bypass_events_deco
     assert update_target_validator_limits_evm_script_factory not in evm_script_factories_before
     assert change_node_operator_managers_evm_script_factory not in evm_script_factories_before
 
+    sanity_checker_limits = contracts.oracle_report_sanity_checker.getOracleReportLimits()
+    assert sanity_checker_limits["maxAccountingExtraDataListItemsCount"] == 2
+
     # START VOTE
     if len(vote_ids_from_env) > 0:
         (vote_id,) = vote_ids_from_env
@@ -256,8 +260,11 @@ def test_vote(helpers, accounts, vote_ids_from_env, stranger, bypass_events_deco
         == EASYTRACK_SIMPLE_DVT_TRUSTED_CALLER
     )
 
+    sanity_checker_limits = contracts.oracle_report_sanity_checker.getOracleReportLimits()
+    assert sanity_checker_limits["maxAccountingExtraDataListItemsCount"] == 4
+
     # validate vote events
-    assert count_vote_items_by_events(vote_tx, contracts.voting) == 18, "Incorrect voting items count"
+    assert count_vote_items_by_events(vote_tx, contracts.voting) == 20, "Incorrect voting items count"
 
     metadata = find_metadata_by_vote_id(vote_id)
     print("metadata", metadata)
@@ -396,15 +403,32 @@ def test_vote(helpers, accounts, vote_ids_from_env, stranger, bypass_events_deco
     )
     validate_staking_module_added_event(evs[17], module_item)
 
+    validate_grant_role_event(evs[18], MAX_ACCOUNTING_EXTRA_DATA_LIST_ITEMS_COUNT_ROLE, agent, agent)
+    validate_max_extra_data_list_items_count_event(evs[19], 4)
+
 
 def has_permission(permission: Permission, how: List[int]) -> bool:
     return contracts.acl.hasPermission["address,address,bytes32,uint[]"](
         permission.entity, permission.app, permission.role, how
     )
 
 
+def validate_max_extra_data_list_items_count_event(event: EventDict, value: int):
+    _events_chain = [
+        "LogScriptCall",
+        "LogScriptCall",
+        "MaxAccountingExtraDataListItemsCountSet",
+        "ScriptResult",
+    ]
+
+    validate_events_chain([e.name for e in event], _events_chain)
+
+    assert event.count("MaxAccountingExtraDataListItemsCountSet") == 1
+    assert event["MaxAccountingExtraDataListItemsCountSet"]["maxAccountingExtraDataListItemsCount"] == value
+
+
 def validate_simple_dvt_intialize_event(event: EventDict):
-    _repo_upgrade_events_chain = [
+    _events_chain = [
         "LogScriptCall",
         "ContractVersionSet",
         "StuckPenaltyDelayChanged",
@@ -413,7 +437,7 @@ def validate_simple_dvt_intialize_event(event: EventDict):
         "StakingModuleTypeSet",
     ]
 
-    validate_events_chain([e.name for e in event], _repo_upgrade_events_chain)
+    validate_events_chain([e.name for e in event], _events_chain)
 
     assert event.count("ContractVersionSet") == 1
     assert event.count("StuckPenaltyDelayChanged") == 1