Skip to content

Commit

Permalink
fix: update id without burner
Browse files Browse the repository at this point in the history
  • Loading branch information
@BATMAH69
BATMAH69 committed Sep 12, 2023
1 parent fd6eb2a commit 2a1bbc6
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 51 deletions.
5 changes: 0 additions & 5 deletions tests/acceptance/test_node_operators_registry.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ def test_nor_state(contract):
assert summary["totalDepositedValidators"] >= 177397
assert summary["depositableValidatorsCount"] > 0

for id in range(node_operators_count):
assert contract.getTotalSigningKeyCount(id) > 0
node_operator = contract.getNodeOperator(id, True)
print(f'{id} - {node_operator["totalExitedValidators"]}')

for id in range(node_operators_count):
assert contract.getTotalSigningKeyCount(id) > 0
node_operator = contract.getNodeOperator(id, True)
Expand Down
109 changes: 63 additions & 46 deletions tests/regression/test_pause_resume.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from utils.test.oracle_report_helpers import oracle_report, prepare_exit_bus_report
from utils.test.helpers import almostEqEth

DEPOSIT_AMOUNT = 100 * 10 ** 18
DEPOSIT_AMOUNT = 100 * 10**18


@pytest.fixture()
Expand Down Expand Up @@ -63,10 +63,15 @@ def test_stop_resume_staking_lido_emit_events(self, helpers):

def test_pause_resume_deposits_staking_module(self, helpers, stranger):
tx = contracts.staking_router.pauseStakingModule(1, {"from": contracts.deposit_security_module})
helpers.assert_single_event_named("StakingModuleStatusSet", tx,
{'setBy': contracts.deposit_security_module,
'stakingModuleId': 1,
'status': StakingModuleStatus.DepositsPaused})
helpers.assert_single_event_named(
"StakingModuleStatusSet",
tx,
{
"setBy": contracts.deposit_security_module,
"stakingModuleId": 1,
"status": StakingModuleStatus.DepositsPaused,
},
)
assert contracts.staking_router.getStakingModuleIsDepositsPaused(1)

contracts.staking_router.grantRole(
Expand All @@ -75,10 +80,11 @@ def test_pause_resume_deposits_staking_module(self, helpers, stranger):
{"from": contracts.agent},
)
tx = contracts.staking_router.resumeStakingModule(1, {"from": stranger})
helpers.assert_single_event_named("StakingModuleStatusSet", tx,
{'setBy': stranger,
'stakingModuleId': 1,
'status': StakingModuleStatus.Active})
helpers.assert_single_event_named(
"StakingModuleStatusSet",
tx,
{"setBy": stranger, "stakingModuleId": 1, "status": StakingModuleStatus.Active},
)
assert contracts.staking_router.getStakingModuleIsActive(1)

def test_stop_staking_module(self, helpers, stranger):
Expand All @@ -88,13 +94,12 @@ def test_stop_staking_module(self, helpers, stranger):
{"from": contracts.agent},
)

tx = contracts.staking_router.setStakingModuleStatus(1,
StakingModuleStatus.Stopped,
{"from": stranger})
helpers.assert_single_event_named("StakingModuleStatusSet", tx,
{'setBy': stranger,
'stakingModuleId': 1,
'status': StakingModuleStatus.Stopped})
tx = contracts.staking_router.setStakingModuleStatus(1, StakingModuleStatus.Stopped, {"from": stranger})
helpers.assert_single_event_named(
"StakingModuleStatusSet",
tx,
{"setBy": stranger, "stakingModuleId": 1, "status": StakingModuleStatus.Stopped},
)

assert contracts.staking_router.getStakingModuleIsStopped(1)

Expand Down Expand Up @@ -151,9 +156,11 @@ def test_revert_second_stop_resume(self):
with brownie.reverts("CONTRACT_IS_ACTIVE"):
contracts.lido.resume({"from": contracts.voting})

@pytest.mark.skip(reason="Second call of pause/resume staking is not reverted right now."
"It maybe should be fixed in the future to be consistent, "
"there's not a real problem with it.")
@pytest.mark.skip(
reason="Second call of pause/resume staking is not reverted right now."
"It maybe should be fixed in the future to be consistent, "
"there's not a real problem with it."
)
def test_revert_second_pause_resume_staking(self):
contracts.lido.pauseStaking({"from": contracts.voting})

Expand All @@ -168,7 +175,7 @@ def test_revert_second_pause_resume_staking(self):
def test_revert_second_pause_resume_staking_module(self, stranger):
contracts.staking_router.pauseStakingModule(1, {"from": contracts.deposit_security_module})

with brownie.reverts(encode_error('StakingModuleNotActive()')):
with brownie.reverts(encode_error("StakingModuleNotActive()")):
contracts.staking_router.pauseStakingModule(1, {"from": contracts.deposit_security_module})

contracts.staking_router.grantRole(
Expand All @@ -178,7 +185,7 @@ def test_revert_second_pause_resume_staking_module(self, stranger):
)
contracts.staking_router.resumeStakingModule(1, {"from": stranger})

with brownie.reverts(encode_error('StakingModuleNotPaused()')):
with brownie.reverts(encode_error("StakingModuleNotPaused()")):
contracts.staking_router.resumeStakingModule(1, {"from": stranger})

def test_revert_second_stop_staking_module(self, helpers, stranger):
Expand All @@ -188,13 +195,9 @@ def test_revert_second_stop_staking_module(self, helpers, stranger):
{"from": contracts.agent},
)

contracts.staking_router.setStakingModuleStatus(1,
StakingModuleStatus.Stopped,
{"from": stranger})
with brownie.reverts(encode_error('StakingModuleStatusTheSame()')):
contracts.staking_router.setStakingModuleStatus(1,
StakingModuleStatus.Stopped,
{"from": stranger})
contracts.staking_router.setStakingModuleStatus(1, StakingModuleStatus.Stopped, {"from": stranger})
with brownie.reverts(encode_error("StakingModuleStatusTheSame()")):
contracts.staking_router.setStakingModuleStatus(1, StakingModuleStatus.Stopped, {"from": stranger})

def test_revert_second_pause_resume_withdrawal_queue(self, helpers, stranger):
inf = contracts.withdrawal_queue.PAUSE_INFINITELY()
Expand All @@ -204,7 +207,7 @@ def test_revert_second_pause_resume_withdrawal_queue(self, helpers, stranger):
{"from": contracts.agent},
)
contracts.withdrawal_queue.pauseFor(inf, {"from": stranger})
with brownie.reverts(encode_error('ResumedExpected()')):
with brownie.reverts(encode_error("ResumedExpected()")):
contracts.withdrawal_queue.pauseFor(inf, {"from": stranger})

contracts.withdrawal_queue.grantRole(
Expand All @@ -213,7 +216,7 @@ def test_revert_second_pause_resume_withdrawal_queue(self, helpers, stranger):
{"from": contracts.agent},
)
contracts.withdrawal_queue.resume({"from": stranger})
with brownie.reverts(encode_error('PausedExpected()')):
with brownie.reverts(encode_error("PausedExpected()")):
contracts.withdrawal_queue.resume({"from": stranger})

def test_revert_second_pause_resume_validators_exit_bus(self, helpers, stranger):
Expand All @@ -224,7 +227,7 @@ def test_revert_second_pause_resume_validators_exit_bus(self, helpers, stranger)
{"from": contracts.agent},
)
contracts.validators_exit_bus_oracle.pauseFor(inf, {"from": stranger})
with brownie.reverts(encode_error('ResumedExpected()')):
with brownie.reverts(encode_error("ResumedExpected()")):
contracts.validators_exit_bus_oracle.pauseFor(inf, {"from": stranger})

contracts.validators_exit_bus_oracle.grantRole(
Expand All @@ -233,12 +236,13 @@ def test_revert_second_pause_resume_validators_exit_bus(self, helpers, stranger)
{"from": contracts.agent},
)
contracts.validators_exit_bus_oracle.resume({"from": stranger})
with brownie.reverts(encode_error('PausedExpected()')):
with brownie.reverts(encode_error("PausedExpected()")):
contracts.validators_exit_bus_oracle.resume({"from": stranger})


# Lido contract tests


@pytest.mark.usefixtures("stopped_lido")
def test_stopped_lido_cant_stake(stranger):
with brownie.reverts("STAKING_PAUSED"):
Expand Down Expand Up @@ -281,11 +285,13 @@ def test_paused_staking_can_report():
contracts.lido.pauseStaking({"from": contracts.voting})
oracle_report()


# Staking module tests


def test_paused_staking_module_cant_stake():
contracts.staking_router.pauseStakingModule(1, {"from": contracts.deposit_security_module})
with brownie.reverts(encode_error('StakingModuleNotActive()')):
with brownie.reverts(encode_error("StakingModuleNotActive()")):
contracts.lido.deposit(1, 1, "0x", {"from": contracts.deposit_security_module}),


Expand All @@ -295,12 +301,12 @@ def test_paused_staking_module_can_reward():
shares_before = contracts.lido.sharesOf(module_address)
(report_tx, _) = oracle_report()
print(report_tx.events["Transfer"])
assert report_tx.events["Transfer"][1]["to"] == module_address
assert report_tx.events["Transfer"][0]["to"] == module_address
assert report_tx.events["Transfer"][0]["from"] == ZERO_ADDRESS
assert report_tx.events["Transfer"][1]["to"] == contracts.agent
assert report_tx.events["Transfer"][1]["from"] == ZERO_ADDRESS
assert report_tx.events["Transfer"][2]["to"] == contracts.agent
assert report_tx.events["Transfer"][2]["from"] == ZERO_ADDRESS
assert almostEqEth(report_tx.events["Transfer"][1]["value"], report_tx.events["Transfer"][1]["value"])
assert report_tx.events["Transfer"][1]["value"] > 0
assert almostEqEth(report_tx.events["Transfer"][0]["value"], report_tx.events["Transfer"][1]["value"])
assert report_tx.events["Transfer"][0]["value"] > 0


def test_stopped_staking_module_cant_stake(stranger):
Expand All @@ -310,9 +316,8 @@ def test_stopped_staking_module_cant_stake(stranger):
{"from": contracts.agent},
)

contracts.staking_router.setStakingModuleStatus(1, StakingModuleStatus.Stopped,
{"from": stranger})
with brownie.reverts(encode_error('StakingModuleNotActive()')):
contracts.staking_router.setStakingModuleStatus(1, StakingModuleStatus.Stopped, {"from": stranger})
with brownie.reverts(encode_error("StakingModuleNotActive()")):
contracts.lido.deposit(1, 1, "0x", {"from": contracts.deposit_security_module}),


Expand All @@ -323,25 +328,28 @@ def test_stopped_staking_module_cant_reward(stranger):
{"from": contracts.agent},
)
_, module_address, *_ = contracts.staking_router.getStakingModule(1)
contracts.staking_router.setStakingModuleStatus(1, StakingModuleStatus.Stopped,
{"from": stranger})
contracts.staking_router.setStakingModuleStatus(1, StakingModuleStatus.Stopped, {"from": stranger})
shares_before = contracts.lido.sharesOf(module_address)
oracle_report()
assert contracts.lido.sharesOf(module_address) == shares_before


def test_stopped_lido_cant_reward(stranger):
contracts.lido.stop({"from": contracts.voting})

with brownie.reverts("CONTRACT_IS_STOPPED"):
oracle_report()


# Withdrawal queue tests


def make_withdrawal_request(stranger):
stranger.transfer(contracts.lido, DEPOSIT_AMOUNT)
contracts.lido.approve(contracts.withdrawal_queue, DEPOSIT_AMOUNT - 1, {"from": stranger})
contracts.withdrawal_queue.requestWithdrawals([DEPOSIT_AMOUNT - 1], stranger, {"from": stranger})


def pause_withdrawal_queue(stranger):
contracts.withdrawal_queue.grantRole(
web3.keccak(text="PAUSE_ROLE"),
Expand All @@ -351,20 +359,24 @@ def pause_withdrawal_queue(stranger):
inf = contracts.withdrawal_queue.PAUSE_INFINITELY()
contracts.withdrawal_queue.pauseFor(inf, {"from": stranger})


def test_paused_withdrawal_queue_cant_withdraw(stranger):
pause_withdrawal_queue(stranger)

with brownie.reverts(encode_error('ResumedExpected()')):
with brownie.reverts(encode_error("ResumedExpected()")):
make_withdrawal_request(stranger)


def test_paused_withdrawal_queue_can_stake(stranger):
pause_withdrawal_queue(stranger)
stranger.transfer(contracts.lido, DEPOSIT_AMOUNT)


def test_paused_withdrawal_queue_can_rebase(stranger):
pause_withdrawal_queue(stranger)
oracle_report()


def test_stopped_lido_cant_withdraw(stranger):
stranger.transfer(contracts.lido, DEPOSIT_AMOUNT)
contracts.lido.approve(contracts.withdrawal_queue, DEPOSIT_AMOUNT - 1, {"from": stranger})
Expand All @@ -377,13 +389,16 @@ def test_stopped_lido_cant_withdraw(stranger):

# Validators exit bus tests


def prepare_report():
ref_slot, _ = contracts.hash_consensus_for_validators_exit_bus_oracle.getCurrentFrame()
consensus_version = contracts.validators_exit_bus_oracle.getConsensusVersion()
items, hash = prepare_exit_bus_report([], ref_slot)
fast_lane_members, _ = contracts.hash_consensus_for_validators_exit_bus_oracle.getFastLaneMembers()
for m in fast_lane_members:
contracts.hash_consensus_for_validators_exit_bus_oracle.submitReport(ref_slot, hash, consensus_version, {"from": m})
contracts.hash_consensus_for_validators_exit_bus_oracle.submitReport(
ref_slot, hash, consensus_version, {"from": m}
)
return items, m


Expand All @@ -396,6 +411,7 @@ def pause_validators_exit_bus(stranger):
inf = contracts.validators_exit_bus_oracle.PAUSE_INFINITELY()
contracts.validators_exit_bus_oracle.pauseFor(inf, {"from": stranger})


def test_paused_validators_exit_bus_cant_submit_report(stranger):
chain.sleep(2 * 24 * 3600)
chain.mine()
Expand All @@ -405,9 +421,10 @@ def test_paused_validators_exit_bus_cant_submit_report(stranger):
pause_validators_exit_bus(stranger)

report, member = prepare_report()
with brownie.reverts(encode_error('ResumedExpected()')):
with brownie.reverts(encode_error("ResumedExpected()")):
contracts.validators_exit_bus_oracle.submitReportData(report, contract_version, {"from": member})


def test_stopped_lido_can_exit_validators(stranger):
chain.sleep(2 * 24 * 3600)
chain.mine()
Expand Down

0 comments on commit 2a1bbc6

Please sign in to comment.