Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Sepolia support #208

Merged
merged 10 commits into from
Apr 24, 2024
Merged

feat: add Sepolia support #208

merged 10 commits into from
Apr 24, 2024

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Apr 5, 2024 •
edited
Loading

Adds minimal Sepolia testnet support, which is required to create a simple vote. Required for #196 and #205.

Warning

Not all parameters are set in configs/config_sepolia.py, and acceptance/regression/snapshot tests are not operational.

@tamtamchik tamtamchik changed the title Feat: add Sepolia support feat: add Sepolia support Apr 5, 2024
TheDZhon
TheDZhon reviewed Apr 5, 2024
View reviewed changes
utils/voting.py Outdated Show resolved Hide resolved
@tamtamchik
Copy link
Member Author 

tests/regression/test_easy_track_factories.py::test_node_operators_activations tests/regression/test_easy_track_factories.py::test_transfer_node_operator_manager =========================== short test summary info ============================
FAILED tests/regression/test_easy_track_factories.py::test_node_operators_activations
FAILED tests/regression/test_easy_track_factories.py::test_transfer_node_operator_manager
===== 2 failed, 280 passed, 14 skipped, 20 warnings in 2068.07s (0:34:28) ======

😢

@tamtamchik tamtamchik marked this pull request as ready for review April 24, 2024 11:23
TheDZhon
TheDZhon requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for only a few details about Infura RPC

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@tamtamchik tamtamchik merged commit 0a63e68 into master Apr 24, 2024
1 check failed
@tamtamchik tamtamchik deleted the feat/sepolia branch April 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamtamchik @TheDZhon