Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tune-up tests after the vote #180 #318

Merged
merged 6 commits into from
Nov 15, 2024
Merged

fix: tune-up tests after the vote #180 #318

merged 6 commits into from
Nov 15, 2024

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Nov 14, 2024 •
edited
Loading

Fix tests:

  • balance_check_middleware rollback balance changes
  • make stake limit tests not requiring the middleware to execute
  • fix negative rebase test to be future-proof against the post-vote state
  • port Oracle report simulation changing the lastProcessingRefSlot as done in the real off-chain lido-oracle code
  • black formatting against the changed files

@TheDZhon TheDZhon requested a review from iamnp November 14, 2024 20:21
@TheDZhon TheDZhon changed the title fix: remove balance_check middleware side effects fix: tune-up tests after the vote #180 Nov 15, 2024
@iamnp iamnp merged commit ae58f35 into feat/next-vote Nov 15, 2024
1 check passed
@TheDZhon TheDZhon deleted the fix/balance-check-fixture branch November 16, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamnp iamnp iamnp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDZhon @iamnp