Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passed missed disabled & id props #467

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Passed missed disabled & id props #467

merged 1 commit into from
Dec 11, 2023

Conversation

hexnickk4997
Copy link
Contributor

Description

Passed disabled and id states to inner input, they were missed during previous refactoring of props passing logic :(

Demo

Screen.Recording.2023-12-11.at.12.41.57.mov

@hexnickk4997 hexnickk4997 requested a review from a team as a code owner December 11, 2023 11:43
Jeday
Jeday approved these changes Dec 11, 2023
View reviewed changes
Copy link

@Jeday Jeday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hexnickk4997 hexnickk4997 merged commit c0a1e00 into main Dec 11, 2023
9 checks passed
@hexnickk4997 hexnickk4997 deleted the feature/ui-1291-disabled-prop-is-not-passed-to-inner-input-component branch December 11, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinamaulitova karinamaulitova karinamaulitova approved these changes

@Jeday Jeday Jeday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hexnickk4997 @Jeday @karinamaulitova