Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build packages with rollup for .mjs extension support #468

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

manneredboor
Copy link
Contributor

Making .js files in the esm build to be under .mjs extension.
It should tell Node that they should be treated as ESM, and we can avoid adding type: module to package.json, which may cause issues with next.js, node and SSR.

Copy link
Contributor

@alx-khramov alx-khramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@hexnickk4997 hexnickk4997 merged commit 345e055 into main Dec 13, 2023
9 checks passed
@hexnickk4997 hexnickk4997 deleted the feature/si-1128-fix-ui-lib-build branch December 13, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants