Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hydration when pass a theme as query param #471

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: hydration when pass a theme as query param #471

merged 1 commit into from
Dec 20, 2023

Conversation

solidovic
Copy link
Contributor

@solidovic solidovic commented Dec 19, 2023 •
edited
Loading

Fix a hydration error in components using withStyledSystem wrapper when get a theme from query param. Actual on SSR mode only.

@solidovic solidovic requested a review from a team December 19, 2023 19:32
@solidovic solidovic marked this pull request as ready for review December 19, 2023 19:48
@solidovic solidovic requested a review from a team as a code owner December 19, 2023 19:48
@karinamaulitova karinamaulitova merged commit 981c76c into main Dec 20, 2023
9 checks passed
@karinamaulitova karinamaulitova deleted the feature/fix-a-theme-hydration-when-pass-the-theme-as-query-param branch December 20, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinamaulitova karinamaulitova karinamaulitova approved these changes

@alx-khramov alx-khramov alx-khramov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solidovic @alx-khramov @karinamaulitova