Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAIN] add license #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarjanaKarzek
Copy link

Hey there,

to support Mike Penz's project "AboutLibraries" (see here: https://github.com/mikepenz/AboutLibraries) it would be great if you could add this license information to your project. After that, it will show up in the list of licenses that we have in our project automatically and we can comply to the MIT license without further ado.

Thanks a lot :)

@pmeinhardt
Copy link

Hey @MarjanaKarzek 🙂 I am terribly sorry it took so long for somebody to get back to you here. 🙇

I didn't really know the AboutLibraries project before, but it looks quite useful so thanks a lot for sharing. 💚

I checked out their documentation and it sounded a bit like the way that the package information is extracted has changed in the meanwhile and they're no longer using *_strings.xml files for that (https://github.com/mikepenz/AboutLibraries/wiki/HOWTODEV:-Include-in-your-library).

Do you know more about this? 🤔

Thanks a lot and again sorry for the long wait.

Kind regards, Paul

@@ -0,0 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="define_LiferyIconBadge"></string>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to add that if this is still necessary the name needs to be adjusted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants