Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Added option to try to sanitize a modified subject if verification fails #469

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented Nov 12, 2024

My mail provider prepends mail subjects with *** UNCHECKED *** or *** SPAM *** or similar. This invalidates the dkim signature.
I added an option on the 2.x branch, which removes any text of the form *...* or [...] from the beginning of the subject and retries verification.

@dodmi dodmi changed the title Added option to try to sanitize a modified subject if verification fails 2.x: Added option to try to sanitize a modified subject if verification fails Dec 24, 2024
lieser
lieser previously approved these changes Jan 1, 2025
Copy link
Owner

@lieser lieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM in general.

But was wondering what your reasoning for what to allow was,

  • Why do you allow adding [...]? Is this for mailing lists that change the subject but don't modify the body?
  • Why do you not enforce something to be between the *...* or [...]? I.e. change the .* in the middle to .+.

Just as a reference in case I will some day port this to the current release, note that this relates too #202.

@lieser lieser added the enhancement Improvements or new features label Jan 1, 2025
@lieser lieser added this to the 2.3.0 milestone Jan 1, 2025
@dodmi
Copy link
Contributor Author

dodmi commented Jan 2, 2025

  • Why do you allow adding [...]? Is this for mailing lists that change the subject but don't modify the body?

Well, I came over additions to the subject, which looked like [Some text here] (indeed a mailing list) and *** Some text here *** (the spam filter of my mail provider). And I tried to find a way to get DKIM verifier to be able to get the right result.

  • Why do you not enforce something to be between the *...* or [...]? I.e. change the .* in the middle to .+.

I changed this to .+, thank you

@lieser lieser merged commit 71c6667 into lieser:2.x Jan 4, 2025
2 checks passed
@dodmi dodmi deleted the new-feature-sanitize-subj-2.x-2024-11-09 branch January 4, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants