Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue & refactor code #301

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Fix issue & refactor code #301

merged 4 commits into from
Sep 7, 2023

Conversation

ashik-75
Copy link
Contributor

@ashik-75 ashik-75 commented Sep 7, 2023

✅ UI

  • Identify and resolve any new warnings in the console
  • Identify and resolve any new errors in the console
  • If there are modifications to configurations such as vite.config.ts, tsconfig.json etc., ensure to include a description

⬜ Automation Scripts

  • Identify and resolve any new warnings in the console
  • Identify and resolve any new errors in the console
  • If there are modifications to configurations such as vite.config.ts, tsconfig.json etc., ensure to include a description

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for binarytree-dev ready!

Name Link
🔨 Latest commit b90a467
🔍 Latest deploy log https://app.netlify.com/sites/binarytree-dev/deploys/64f994ac876c150008368c54
😎 Deploy Preview https://deploy-preview-301--binarytree-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 61
Accessibility: 85
Best Practices: 100
SEO: 69
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashik-75 ashik-75 changed the title Work Fix issue & refactor code Sep 7, 2023
@@ -1,4 +1,7 @@
.toc {
height: calc(100dvh - 70px);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to a css variable under sizes.css

@lifeparticle lifeparticle merged commit 32d4ad4 into lifeparticle:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants