Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor newsfeed #444

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Refactor newsfeed #444

merged 6 commits into from
Mar 29, 2024

Conversation

lifeparticle
Copy link
Owner

Pull Request Overview

Please provide a brief summary of the changes made in this pull request. This helps reviewers understand the context and intent of your changes.

Changes Introduced

List specific changes made (e.g., added new component, refactored existing logic).Include reasons for complex or significant changes

Linked Issue(s)

  • Link to the issue ticket(s) this PR addresses (e.g., Fixes #123)

Testing Strategy

  • Describe how you have tested these changes
  • Include details of any new unit/integration tests added
  • Mention any edge cases considered or testing environments (e.g., browser versions, mobile)

Performance and Accessibility Considerations

  • Confirm no significant performance drops. Use tools like Lighthouse for performance evaluation.
  • Ensure new UI components are accessible (e.g., screen reader-friendly, keyboard navigable)

Code Quality Checks

  • Confirm self-review of code, including readability and maintainability
  • Verify adherence to project coding standards
  • Ensure proper documentation of functions and classes, if applicable

Console Warning/Error Checks

  • Confirm no new warnings or errors are showing in the console

Configuration Changes

  • If applicable, describe any changes to project configurations (e.g., vite.config.ts, tsconfig.json)

Screenshots/Video

  • Include screenshots/video demonstrating UI changes (if applicable)

Additional Notes

  • Add any other context or notes about the pull request here (optional)

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
binarytree-rssfeed-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 2:20am

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for binarytree-dev ready!

Name Link
🔨 Latest commit 708c5d1
🔍 Latest deploy log https://app.netlify.com/sites/binarytree-dev/deploys/66062560b39d02000872ab2c
😎 Deploy Preview https://deploy-preview-444--binarytree-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Warnings
⚠️ You have not included a CHANGELOG entry.

Generated by 🚫 dangerJS against 708c5d1

@lifeparticle lifeparticle merged commit cf7dbf3 into main Mar 29, 2024
11 checks passed
@lifeparticle lifeparticle deleted the refactor-newsfeed branch March 29, 2024 02:23
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)
12.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant