[#395] Fix some sonar cloud issues #452

panagiotisbellias · 2024-04-17T12:39:45Z

Pull Request Overview

Fix some sonar issues

Changes Introduced

Fix some sonar issues

Linked Issue(s)

Fixes Sonar cloud issues #395

Testing Strategy

Describe how you have tested these changes
Include details of any new unit/integration tests added
Mention any edge cases considered or testing environments (e.g., browser versions, mobile)

Performance and Accessibility Considerations

Confirm no significant performance drops. Use tools like Lighthouse for performance evaluation.
Ensure new UI components are accessible (e.g., screen reader-friendly, keyboard navigable)

Code Quality Checks

Confirm self-review of code, including readability and maintainability
Verify adherence to project coding standards
Ensure proper documentation of functions and classes, if applicable

Console Warning/Error Checks

Confirm no new warnings or errors are showing in the console

Configuration Changes

If applicable, describe any changes to project configurations (e.g., vite.config.ts, tsconfig.json)

Screenshots/Video

Include screenshots/video demonstrating UI changes (if applicable)

Additional Notes

Add any other context or notes about the pull request here (optional)

vercel · 2024-04-17T12:39:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
binarytree-rssfeed-api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 21, 2024 0:05am

netlify · 2024-04-17T12:40:03Z

✅ Deploy Preview for binarytree-dev ready!

Name	Link
🔨 Latest commit	`cc6a34a`
🔍 Latest deploy log	https://app.netlify.com/sites/binarytree-dev/deploys/664c8e02c8f72c0008733965
😎 Deploy Preview	https://deploy-preview-452--binarytree-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lifeparticle · 2024-04-18T07:02:38Z

@panagiotisbellias Thank you for your contribution. Could you please check the build at https://app.netlify.com/sites/binarytree-dev/deploys/661fc3144c127300088d48c0 It seems to be failing.

Let me know if you have any questions.

panagiotisbellias · 2024-04-18T07:06:31Z

I'll check it as soon as possible

lifeparticle · 2024-05-04T15:18:22Z

ui/index.html

@@ -57,6 +57,7 @@

 		<link rel="manifest" href="/manifest.json" />
 		<meta name="theme-color" content="#141414" />
+		<title></title>


@panagiotisbellias have you tested this code?

@lifeparticle No, please confirm that I can run the application navigating to the ui directory and running npm install. Also, please provide the proper NodeJS version so I can test the code

Thanks,
Panagiotis

@panagiotisbellias please follow the steps here, https://github.com/lifeparticle/binarytree/blob/main/ui/CONTRIBUTING.md

Thanks

@lifeparticle I'm on it, thanks

@lifeparticle I'm facing issues installing yarn. The v3.6.1 cannot be found either from Windows or WSL (Ubuntu 22.04)

@panagiotisbellias make sure that you're inside the ui folder

Ok, now I did it with some warnings though. I see that the title is gone this way so i'm adding the correct title in the html element. This is good to be configurable though reading the title from the previous location

@lifeparticle Hi, if more actions are needed by me please inform me or close this PR. Thanks

@panagiotisbellias, please pull the latest from the main and review your changes. For example,

Does this file need any cleanup? ui/src/components/Layouts/PageGrid/PageGrid.tsx

Does the title change for every page? ui/index.html

Thanks

@lifeparticle Latest changes generated merge confilcts with my side branch, so I'm closing this pull request and open a new one for the same issue when time

Thanks

lifeparticle · 2024-05-04T15:19:41Z

ui/src/components/Layouts/InputGrid/InputGrid.tsx

 					{child}
 				</Col>
 			))}
 		</Row>
 	);
 };

+// Function to generate unique keys based on child content
+const getKey = (child: React.ReactNode): string => {


@panagiotisbellias can you please share more about this approach. For example any articles, docs etc

In this project we don't write helper functions inside a component.

@panagiotisbellias can you please share more about this approach. For example any articles, docs etc

@lifeparticle To avoid using array indices as keys, I generated unique keys for each child element using a unique identifier associated with each child element. In the getKey function, I generated the key based on the content of each child element. This ensures that each child has a unique key without relying on array indices. Probably this needs testing too when above information is provided.

In this project we don't write helper functions inside a component.

I'm sorry, didn't notice. Please confirm that the correct location for the helper function (after testing it) should be ui/src/utils/helper-functions

Thanks,
Panagiotis

@panagiotisbellias Thank you for the explanation. Can you please check the official doco here, https://react.dev/learn/rendering-lists

I'm not sure if this is the right approach to generate a key.

Please put it in the same directory ./helper.ts

Thanks

@lifeparticle Indeed this is not the right approach to generate a key. This has to be done per case according to what attributes each list's object have like id, uuid etc. But here is very generic so I suggest to keep this sonar issue until a better solution comes out

[lifeparticle#395] Fix some sonar cloud issues

22567e5

vercel bot deployed to Preview April 17, 2024 12:40 View deployment

lifeparticle self-requested a review April 18, 2024 06:48

[lifeparticle#395] Fix build issue

758facb

vercel bot deployed to Preview April 18, 2024 07:12 View deployment

[lifeparticle#395] Fix build issue

67133af

vercel bot deployed to Preview April 18, 2024 07:14 View deployment

[lifeparticle#395] Fix build issue

886aa18

vercel bot deployed to Preview April 18, 2024 07:16 View deployment

[lifeparticle#395] Fix more sonar issues

88c7d9e

vercel bot deployed to Preview April 18, 2024 12:15 View deployment

[lifeparticle#395] Remove useless vars

d2e9674

vercel bot deployed to Preview April 18, 2024 12:18 View deployment

lifeparticle reviewed May 4, 2024

View reviewed changes

Merge branch 'main' into issue-395-sonar-issues

faa1803

vercel bot deployed to Preview May 5, 2024 20:11 View deployment

panagiotisbellias added 2 commits May 13, 2024 10:06

Merge branch 'main' into issue-395-sonar-issues

f730b29

[lifeparticle#395] Revert sonar issue fix

e33e668

vercel bot deployed to Preview May 13, 2024 08:23 View deployment

Merge branch 'main' into issue-395-sonar-issues

2a6e8dc

vercel bot deployed to Preview May 19, 2024 16:09 View deployment

[lifeparticle#395] Fix title

cc6a34a

vercel bot deployed to Preview May 21, 2024 12:05 View deployment

panagiotisbellias closed this Jun 23, 2024

panagiotisbellias deleted the issue-395-sonar-issues branch June 23, 2024 12:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#395] Fix some sonar cloud issues #452

[#395] Fix some sonar cloud issues #452

panagiotisbellias commented Apr 17, 2024

vercel bot commented Apr 17, 2024 •

edited

Loading

netlify bot commented Apr 17, 2024 •

edited

Loading

lifeparticle commented Apr 18, 2024

panagiotisbellias commented Apr 18, 2024

lifeparticle May 4, 2024

panagiotisbellias May 5, 2024

lifeparticle May 12, 2024

panagiotisbellias May 12, 2024

panagiotisbellias May 13, 2024

lifeparticle May 21, 2024

panagiotisbellias May 21, 2024

panagiotisbellias Jun 16, 2024 •

edited

Loading

lifeparticle Jun 17, 2024

panagiotisbellias Jun 23, 2024 •

edited

Loading

lifeparticle May 4, 2024

lifeparticle May 4, 2024

panagiotisbellias May 5, 2024 •

edited

Loading

lifeparticle May 12, 2024

panagiotisbellias May 13, 2024 •

edited

Loading

[#395] Fix some sonar cloud issues #452

[#395] Fix some sonar cloud issues #452

Conversation

panagiotisbellias commented Apr 17, 2024

Pull Request Overview

Changes Introduced

Linked Issue(s)

Testing Strategy

Performance and Accessibility Considerations

Code Quality Checks

Console Warning/Error Checks

Configuration Changes

Screenshots/Video

Additional Notes

vercel bot commented Apr 17, 2024 • edited Loading

netlify bot commented Apr 17, 2024 • edited Loading

✅ Deploy Preview for binarytree-dev ready!

lifeparticle commented Apr 18, 2024

panagiotisbellias commented Apr 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panagiotisbellias Jun 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panagiotisbellias Jun 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panagiotisbellias May 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panagiotisbellias May 13, 2024 • edited Loading

Choose a reason for hiding this comment

vercel bot commented Apr 17, 2024 •

edited

Loading

netlify bot commented Apr 17, 2024 •

edited

Loading

panagiotisbellias Jun 16, 2024 •

edited

Loading

panagiotisbellias Jun 23, 2024 •

edited

Loading

panagiotisbellias May 5, 2024 •

edited

Loading

panagiotisbellias May 13, 2024 •

edited

Loading