LPD-1476 AuthVerifier imp. #1645

stian-sigvartsen · 2024-02-22T22:48:21Z

No description provided.

… requirements like email verification

…and avoid double checks

stian-sigvartsen · 2024-02-22T22:49:35Z

ci:test:sf

stian-sigvartsen · 2024-02-22T22:49:41Z

ci:test:relevant

stian-sigvartsen · 2024-02-23T07:36:00Z

ci:test:sf

liferay-continuous-integration · 2024-02-23T07:40:34Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 97039be0c54337fe719879d08bd5f83cb0108456

Sender Branch:

Branch Name: LPD-1476-i-1
Branch GIT ID: 1e37e9d425c6890083169e18f7a0d51479c4ed87

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-02-23T07:44:45Z

Jenkins Build:test-portal-source-format#5139

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-appsec#1645

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - liferay-appsec > liferay-appsec - PR#1645 - 2024-02-22[23:36:11]

Testray Build ID:2542402771

Testray Importer:publish-testray-report#20146

stian-sigvartsen · 2024-02-23T07:47:26Z

ci:test:relevant

liferay-continuous-integration · 2024-02-23T12:46:40Z

❌ ci:test:stable - 31 out of 32 jobs passed

❌ ci:test:relevant - 125 out of 232 jobs passed in 3 hours 21 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 97039be0c54337fe719879d08bd5f83cb0108456

Upstream Comparison:

Branch GIT ID: 97039be0c54337fe719879d08bd5f83cb0108456
Jenkins Build URL: EE Development Acceptance (master) - 376 - 2024-02-22[17:06:37]

ci:test:stable - 31 out of 32 jobs PASSED

1 Failed Jobs:

build-iw-jdk8
- build-iw-jdk8/0/0
central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- ~~functional-smoke-tomcat90-mysql57-jdk8_stable/0/0~~
functional-upgrade-tomcat90-mysql57-jdk8_stable
js-unit-jdk8
- js-unit-jdk8/0/0
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
- modules-integration-mysql57-jdk8_stable/0/0
- modules-integration-mysql57-jdk8_stable/0/1
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
playwright-js-tomcat90-mysql57-jdk8_stable
- playwright-js-tomcat90-mysql57-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-mysql57-jdk8
- portal-license-smoke-mysql57-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0
workspaces-compile-jdk8
- workspaces-compile-jdk8/0/0

31 Successful Jobs:

ci:test:relevant - 125 out of 232 jobs PASSED

107 Failed Jobs:

125 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-tomcat90-mysql57-chrome100-jdk8/0/0

     [exec] * What went wrong:
     [exec] Execution failed for task ':runPoshi'.
     [exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html
     [exec] 
     [exec] * Try:
     [exec] > Run with --stacktrace option to get the stack trace.
     [exec] > Run with --info or --debug option to get more log output.
     [exec] > Run with --scan to get full insights.
     [exec] 
     [exec] * Get more help at https://help.gradle.org
     [exec] 
     [exec] BUILD FAILED in 1m 45s
     [exec] 
     [exec] > Task :runPoshi FAILED
     [exec] Gradle build finished at 2024-02-23 11:56:46.603.
     [exec] 3 actionable tasks: 2 executed, 1 up-to-date
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2024-02-23-03-55-03.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] Result: 1
     [copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/897843
     [copy] Copying 6 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-downstream(master)/builds/897843/screenshots
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null327331357.properties
clean-up-selenium-driver:

[echo] Executing commands:

[echo]

[echo] docker logs test-1-30-55.lax.liferay.com_chrome > /tmp/jenkins/test-1-30/test-portal-acceptance-pullrequest-downstream(master)/897843/docker-logs/test-1-30-55.lax.liferay.com_chrome.log

[echo]

[echo] https://test-1-36.liferay.com/userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/5221/functional-tomcat90-mysql57-chrome100-jdk8/0/0/docker-logs/test-1-30-55.lax.liferay.com_chrome.log

[echo] Executing commands:

[echo] killall chromedriver

[exec] chromedriver: no process found

[exec] Result: 1

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null327331357.properties
stop-analytics-cloud:

[echo] Executing commands:

[echo]

[echo] docker logs bigqueryemulator > /tmp/jenkins/test-1-30/test-portal-acceptance-pullrequest-downstream(master)/897843/docker-logs/bigqueryemulator.log

[echo]

LocalFile.ConnectACWithDXP#CheckIsPossibleConnectACWithValidToken - Poshi Report - Poshi Summary - Poshi Console - Console Output

functional-smoke-tomcat90-db2115-jdk8/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output - Failed 1 of last 24
functional-smoke-tomcat90-hypersonic20-jdk8/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output
functional-smoke-tomcat90-mysql57-jdk11_open/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output - Failed 0 of last 24
functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output - Failed 0 of last 25
...

liferay-continuous-integration · 2024-02-23T12:54:22Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5221

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-appsec#1645

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - liferay-appsec > liferay-appsec - PR#1645 - 2024-02-23[01:08:07]

Testray Build ID:2542486170

Testray Importer:publish-testray-report#11287

stian-sigvartsen · 2024-02-23T15:33:19Z

ci:test:relevant

liferay-continuous-integration · 2024-02-23T18:14:16Z

❌ ci:test:stable - 31 out of 32 jobs passed

❌ ci:test:relevant - 129 out of 232 jobs passed in 2 hours 33 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 97039be0c54337fe719879d08bd5f83cb0108456

Upstream Comparison:

Branch GIT ID: 97039be0c54337fe719879d08bd5f83cb0108456
Jenkins Build URL: EE Development Acceptance (master) - 376 - 2024-02-22[17:06:37]

ci:test:stable - 31 out of 32 jobs PASSED

1 Failed Jobs:

build-iw-jdk8
- build-iw-jdk8/0/0
central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- ~~functional-smoke-tomcat90-mysql57-jdk8_stable/0/0~~
functional-upgrade-tomcat90-mysql57-jdk8_stable
js-unit-jdk8
- js-unit-jdk8/0/0
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
- modules-integration-mysql57-jdk8_stable/0/0
- modules-integration-mysql57-jdk8_stable/0/1
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
playwright-js-tomcat90-mysql57-jdk8_stable
- playwright-js-tomcat90-mysql57-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-mysql57-jdk8
- portal-license-smoke-mysql57-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0
workspaces-compile-jdk8
- workspaces-compile-jdk8/0/0

31 Successful Jobs:

ci:test:relevant - 129 out of 232 jobs PASSED

103 Failed Jobs:

129 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-tomcat90-mysql57-chrome100-jdk8/0/0

     [exec] Network test-1-25-87 is external, skipping
     [exec] Removing volume com-liferay-osb-asah-private_backup
     [exec] Removing volume com-liferay-osb-asah-private_export
     [exec] Removing volume com-liferay-osb-asah-private_faro
     [exec] Removing volume com-liferay-osb-asah-private_mariadbdata
     [exec] Removing volume com-liferay-osb-asah-private_psqldata
     [exec] Removing volume com-liferay-osb-asah-private_storage
     [exec] Removing volume com-liferay-osb-asah-private_temp
     [exec] TYPE            TOTAL     ACTIVE    SIZE      RECLAIMABLE
     [exec] Images          79        5         92.23GB   82.59GB (89%)
     [exec] Containers      6         6         15.6GB    0B (0%)
     [exec] Local Volumes   4         1         513MB     163.6MB (31%)
     [exec] Build Cache     51        0         0B        0B
     [echo] Failed to create Analytics Cloud demo data.
[stopwatch] [test.execution.duration: 54:03.547 sec]
[stopwatch] [run.batch.test.action: 54:55.972 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:373: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1678: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1682: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:38: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:50: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:16284: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-analytics-cloud.xml:563: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-analytics-cloud.xml:423: Failed to start Analytics Cloud with error code 143.
      [get] Getting: \$\{dependencies.url\}/archive/test-1-25/test-portal-acceptance-pullrequest-downstream(master)/535370consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20240223094929646.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20240223094929646.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null2004983382.properties

LocalFile.ConnectACWithDXP#CheckIsPossibleConnectACWithValidToken - Poshi Report - Poshi Summary - Poshi Console - Console Output

functional-smoke-tomcat90-db2115-jdk8/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output - Failed 1 of last 24
functional-smoke-tomcat90-hypersonic20-jdk8/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output
functional-smoke-tomcat90-mysql57-jdk11_open/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output - Failed 0 of last 24
functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output - Failed 0 of last 25
...

liferay-continuous-integration · 2024-02-23T18:19:11Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5235

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-appsec#1645

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - liferay-appsec > liferay-appsec - PR#1645 - 2024-02-23[07:33:29]

Testray Build ID:2542761693

Testray Importer:publish-testray-report#11304

stian-sigvartsen · 2024-02-23T18:26:14Z

ci:test:stable

liferay-continuous-integration · 2024-02-23T20:50:19Z

❌ ci:test:stable - 31 out of 33 jobs passed in 2 hours 23 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 97039be0c54337fe719879d08bd5f83cb0108456

ci:test:stable - 31 out of 33 jobs PASSED

2 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
build-iw-jdk8
- build-iw-jdk8/0/0
central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- ~~functional-smoke-tomcat90-mysql57-jdk8_stable/0/0~~
functional-upgrade-tomcat90-mysql57-jdk8_stable
js-unit-jdk8
- js-unit-jdk8/0/0
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
- modules-integration-mysql57-jdk8_stable/0/0
- modules-integration-mysql57-jdk8_stable/0/1
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
playwright-js-tomcat90-mysql57-jdk8_stable
- playwright-js-tomcat90-mysql57-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-mysql57-jdk8
- portal-license-smoke-mysql57-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0
workspaces-compile-jdk8
- workspaces-compile-jdk8/0/0

31 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
1. com.liferay.portal.log.assertor.PortalLogAssertorTest
  testScanXMLLog
2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Poshi Console - Console Output - Failed 0 of last 25

For upstream results, click here.

liferay-continuous-integration · 2024-02-23T20:53:19Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#3772

Jenkins Report:jenkins-report.html

Jenkins Suite:stable

Pull Request:liferay-appsec#1645

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:stable - liferay-appsec > liferay-appsec - PR#1645 - 2024-02-23[10:26:27]

Testray Build ID:2542794840

Testray Importer:publish-testray-report#31176

stian-sigvartsen · 2024-02-26T09:33:50Z

CI relevant failures seems relates:

[exec]     Executing commands: curl -X GET -u '[email protected]:test' http://localhost:8080/api/jsonws/company/get-company-by-virtual-host/virtual-host/test-1-40-79.lax.liferay.com
[beanshell] 2024-02-23 20:06:31.874 ERROR [http-nio-8080-exec-4][AuthVerifierFilter:53] com.liferay.portal.kernel.security.auth.AuthException: No User exists with the primary key 0

ChrisKian · 2024-02-27T01:50:37Z

Looking into the error. I'm having trouble compiling master to test locally.

jkappler · 2024-04-19T10:42:41Z

Hi @stian-sigvartsen, @ChrisKian, any news on this?

Regards

ChrisKian · 2024-04-22T18:40:34Z

Hey @jkappler,
This one slipped through the cracks. I'll need to revisit and potentially rework the solution

stian-sigvartsen · 2024-11-07T19:52:08Z

The requirements changed. See ticket for details. I am closing this PR, but have archived it to stian-sigvartsen/pull/311 for future reference.

ChrisKian and others added 7 commits February 22, 2024 22:29

LPD-1476 If user is being properly impersonated, we can skip business…

6892bf3

… requirements like email verification

LPD-1476 ant build-services (manually added, since command didn't work)

c1ca4ec

LPD-1476 Refactor to make the make the condition more human readable …

c8e6eb1

…and avoid double checks

LPD-1476 Basically we are not allowing users whose setup is incomplete

e1dcf7a

LPD-1476 Only FORM_AUTH supports impersonation

ad90220

LPD-1476 The caller should not have to unwrap the HttpServletRequest

89defed

LPD-1476 Be more precise

1e37e9d

stian-sigvartsen force-pushed the LPD-1476-i-1 branch from 08ca668 to 1e37e9d Compare February 22, 2024 22:49

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Feb 23, 2024

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 23, 2024

LPD-1476 SemVer

1ec5aea

liferay-continuous-integration added ci:test:relevant - pending and removed ci:test:relevant - failure ci:test:stable - failure labels Feb 23, 2024

liferay-continuous-integration added ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 23, 2024

liferay-continuous-integration added ci:test:stable - pending ci:test:stable - failure and removed ci:test:stable - failure ci:test:stable - pending labels Feb 23, 2024

stian-sigvartsen mentioned this pull request Feb 26, 2024

LPS-204744 #1601

Closed

zsigmondrab added delegation backlog and removed delegation labels Apr 23, 2024

stian-sigvartsen closed this Nov 7, 2024

LPD-1476 AuthVerifier imp. #1645

LPD-1476 AuthVerifier imp. #1645

Conversation

stian-sigvartsen commented Feb 22, 2024

stian-sigvartsen commented Feb 22, 2024

stian-sigvartsen commented Feb 22, 2024

stian-sigvartsen commented Feb 23, 2024

liferay-continuous-integration commented Feb 23, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 23, 2024

stian-sigvartsen commented Feb 23, 2024

liferay-continuous-integration commented Feb 23, 2024

❌ ci:test:stable - 31 out of 32 jobs passed

❌ ci:test:relevant - 125 out of 232 jobs passed in 3 hours 21 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

107 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Feb 23, 2024

stian-sigvartsen commented Feb 23, 2024

liferay-continuous-integration commented Feb 23, 2024

❌ ci:test:stable - 31 out of 32 jobs passed

❌ ci:test:relevant - 129 out of 232 jobs passed in 2 hours 33 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

103 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Feb 23, 2024

stian-sigvartsen commented Feb 23, 2024

liferay-continuous-integration commented Feb 23, 2024

❌ ci:test:stable - 31 out of 33 jobs passed in 2 hours 23 minutes

Base Branch:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

liferay-continuous-integration commented Feb 23, 2024

stian-sigvartsen commented Feb 26, 2024

ChrisKian commented Feb 27, 2024

jkappler commented Apr 19, 2024

ChrisKian commented Apr 22, 2024

stian-sigvartsen commented Nov 7, 2024 • edited Loading

stian-sigvartsen commented Nov 7, 2024 •

edited

Loading