Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-1977 make basic auth verifier return 401 for invalid basic auth #2035

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cdbm
Copy link
Collaborator

@cdbm cdbm commented Oct 28, 2024

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

The following guidelines have been set by the owner of this repository:

  •     "Thank you for sending this PR to liferay-appsec! Here is the guide about 'How to send Pull Requests to the Application Security Team liferay-appsec'. For additional help,reach out in the #help-app-security Slack channel."

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@cdbm
Copy link
Collaborator Author

cdbm commented Oct 28, 2024

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d942b87f098bcaa055c7fdf57a494ee104ad249f

Sender Branch:

Branch Name: LPS-205582
Branch GIT ID: 5a974f9fdcc5af6024e411869a7a3cce38d9f259

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Pull Request:liferay-appsec#2035
Testray Routine:EE Pull Request
Testray Build ID:54026266

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 28 out of 31 jobs passed in 1 hour 59 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d942b87f098bcaa055c7fdf57a494ee104ad249f

Upstream Comparison:

Branch GIT ID: c0bb054bcb5c23d6167852cfc972fb7a81a560b4
Jenkins Build URL: EE Development Acceptance (master) - 955 - 2024-10-28[12:45:00]

ci:test:stable - 24 out of 24 jobs PASSED
24 Successful Jobs:
    ci:test:relevant - 28 out of 31 jobs PASSED

    3 Failed Jobs:

    28 Successful Jobs:
      For more details click here.

      Failures unique to this pull:


      Failures in common with acceptance upstream results at c0bb054:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @cdbm
      Copy link
      Collaborator Author

      cdbm commented Oct 29, 2024

      ci:report:54294324

      1 similar comment
      @cdbm
      Copy link
      Collaborator Author

      cdbm commented Oct 29, 2024

      ci:report:54294324

      @liferay-continuous-integration
      Copy link
      Collaborator

      Build completed.

      Testray CSV has been generated successfully for testrayBuildID: 54294324.

      Job Link: generate-testray-csv

      Testray CSV Link: testray-results-54294324.csv

      @cdbm
      Copy link
      Collaborator Author

      cdbm commented Oct 29, 2024

      errors are unrelated, both tests fail constantly

      @ChrisKian ChrisKian self-requested a review October 29, 2024 17:01
      Copy link
      Collaborator

      @ChrisKian ChrisKian left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Looks good, thanks @cdbm. Requesting review from @stian-sigvartsen

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      3 participants