Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lpd 38816 v4 #2098

Closed
wants to merge 5 commits into from
Closed

Lpd 38816 v4 #2098

wants to merge 5 commits into from

Conversation

alvarosaugarlr
Copy link
Collaborator

move UI login to jsp
add debault.admin.password logic

@liferay-continuous-integration
Copy link
Collaborator

The following guidelines have been set by the owner of this repository:

  •     "Thank you for sending this PR to liferay-appsec! Here is the guide about 'How to send Pull Requests to the Application Security Team liferay-appsec'. For additional help,reach out in the #help-app-security Slack channel."

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 038adf331615d04defca67065fc452207d955f0b

Sender Branch:

Branch Name: LPD-38816-evibuda-v4
Branch GIT ID: 7f818e55c035cf456e8ac223a003b85d85b18cdd

0 out of 1jobs PASSED
For more details click here.
format-source-files:
     [java] java.lang.Exception: Found 4 formatting issues:
     [java] 1: > 80: ./modules/apps/portal-security/portal-security-auto-login-test/src/testIntegration/java/com/liferay/portal/security/auto/login/test/UpdatePasswordActionTest.java 93 (SourceCheck:JavaLongLinesCheck)
     [java] 2: Missing parentheses, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/if_statement_check.markdown: ./portal-web/docroot/html/portal/update_password.jsp 65 (SourceCheck:JSPParenthesesCheck)
     [java] 3: Redundant parentheses, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/if_statement_check.markdown: ./portal-web/docroot/html/portal/update_password.jsp 65 (SourceCheck:JSPParenthesesCheck)
     [java] 4: ./portal-web/docroot/html/portal/init.jsp expected:<...portal.kernel.util.P[]rogressTracker" %><%...> but was:<...portal.kernel.util.P[aramUtil" %><%@
     [java] page import="com.liferay.portal.kernel.util.P]rogressTracker" %><%...>
     [java] 
     [java]   at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:472)
     [java]   at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:301)
[stopwatch] [run.batch.test.action: 1:51.312 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:497: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:650: Java returned: 1
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1404150671.properties

merge-test-results:
[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
[beanshell] Truncating errors in /opt/dev/projects/github/liferay-portal/portal-impl/test-results/TEST-JenkinsLogAssertTest.xml
[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null1413602155
[junitreport] Loading stylesheet ile:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 149ms

@liferay-continuous-integration
Copy link
Collaborator

@alvarosaugarlr alvarosaugarlr changed the title Lpd 38816 Lpd 38816 v4 Dec 2, 2024
@alvarosaugarlr alvarosaugarlr mentioned this pull request Dec 2, 2024
@stian-sigvartsen
Copy link
Collaborator

Just to record here that we discussed this approach and we believe it is the best approach to pursue.
There are some issues with it which @alvarosaugarlr will investigate further.

@alvarosaugarlr
Copy link
Collaborator Author

working on - #2151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants