-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lpd 38816 v4 #2098
Lpd 38816 v4 #2098
Conversation
…ser is logged in and active
…n the user is logged in
The following guidelines have been set by the owner of this repository:
|
CI is automatically triggering the following test suites:
|
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-38816-evibuda-v4 1 Failed Jobs:For more details click here.format-source-files: [java] java.lang.Exception: Found 4 formatting issues: [java] 1: > 80: ./modules/apps/portal-security/portal-security-auto-login-test/src/testIntegration/java/com/liferay/portal/security/auto/login/test/UpdatePasswordActionTest.java 93 (SourceCheck:JavaLongLinesCheck) [java] 2: Missing parentheses, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/if_statement_check.markdown: ./portal-web/docroot/html/portal/update_password.jsp 65 (SourceCheck:JSPParenthesesCheck) [java] 3: Redundant parentheses, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/if_statement_check.markdown: ./portal-web/docroot/html/portal/update_password.jsp 65 (SourceCheck:JSPParenthesesCheck) [java] 4: ./portal-web/docroot/html/portal/init.jsp expected:<...portal.kernel.util.P[]rogressTracker" %><%...> but was:<...portal.kernel.util.P[aramUtil" %><%@ [java] page import="com.liferay.portal.kernel.util.P]rogressTracker" %><%...> [java] [java] at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:472) [java] at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:301) [stopwatch] [run.batch.test.action: 1:51.312 sec] [echo] The following error occurred while executing this line: [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:497: The following error occurred while executing this line: [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:650: Java returned: 1 [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found. [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found. [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1404150671.properties |
Jenkins Build:test-portal-source-format#6886 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-appsec#2098 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - liferay-appsec > liferay-appsec - PR#2098 - 2024-12-02[03:25:09] Testray Build ID:81548167 Testray Importer:publish-testray-report#26226 |
Just to record here that we discussed this approach and we believe it is the best approach to pursue. |
working on - #2151 |
move UI login to jsp
add debault.admin.password logic