-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New localization strings (WIP) #193
base: main
Are you sure you want to change the base?
Conversation
|
chrome beta/scripts/emerald.js
Outdated
@@ -1348,7 +1438,7 @@ function createWatch4(wV) { | |||
<div id="watch4-views-info"> | |||
<div id="watch4-view-count"> | |||
<span id="js-view-count">???,???</span> | |||
<span id="views-text"> views</span> | |||
<span id="views-text">${emeraldLanguageModel.views}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space missing
If that's not a problem, I can commit over these changes to fix up some things so they remain being correct, and add some stuff that is not in the original code yet to improve localization. |
Okay. |
I'm not sure why some things are put into several Also there should be separate localization for each layout, because some stuff is inaccurate, and fixing it will make other layouts inaccurate. For fully proper localization I'd suggest the project owner to consider using placeholders. For example:
instead of
because the issue with the latter is that, for example, Polish version of Cosmic Panda layout had And the thing that I guess the project owner is aware of is that some text is defined in |
I added more localization strings. I need to figure out how to change the separator in the view count from "," to " " (non-breaking space) and make the sub count match the text "subskrybentów". For example, it is supposed to be "50 454", not "50,4 tys. subskrybentów". Can you help me with this?