Added Router BeforeAll Hook #228
Open
+56
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
suresh-gangumalla
commented
Nov 27, 2024
suresh-gangumalla
commented
- Updated Router configuration to include router hooks along with routes from Application instance
- Executing router beforeAll hook on every route navigation
- Updated Router configuration to include router hooks along with routes from Application instance - Executing router beforeAll hook on every route navigation Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
michielvandergeest
requested changes
Dec 10, 2024
There was a problem hiding this comment.
This code looks good, but as far as I understand it's now only possible to provide a router object in the ApplicationConfig
I think ideally we would keep the 'simple' configuration with direct routes (using the routes-property, along side the advanced configuration using the router-key.
If possible, the Typescript definitions should indicate that only 1 configuration (routes vs router) is allowed at the same time
Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.