Remove deprecated python-teos submodule, use rust-teos instead #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberm
changed the title
vincenzopalazzo
previously approved these changes
Feb 7, 2024
chrisguida
reviewed
Feb 7, 2024
seberm
force-pushed
the
replace-python-teos-with-watchtower
branch
from
23d5bb3 to
70ab474
Compare
mergify
bot
dismissed stale reviews from chrisguida and vincenzopalazzo
Pull request has been modified.
seberm
force-pushed
the
replace-python-teos-with-watchtower
branch
from
70ab474 to
ba9ff58
Compare
chrisguida
reviewed
Feb 13, 2024
chrisguida
reviewed
Feb 13, 2024
chrisguida
reviewed
Feb 13, 2024
chrisguida
previously requested changes
Feb 13, 2024
seberm
force-pushed
the
replace-python-teos-with-watchtower
branch
from
ba9ff58 to
5eea140
Compare
vincenzopalazzo
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
ACK 5eea140
I vote in favor to have watchtower-client to have in, also rust-teos was a good name but nevermind it is a minors things
|
Looks great, thanks @seberm ! @vincenzopalazzo looks like you can merge things! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
python-teossubmodule and replace it bywatchtowerwhich links to rust-teos.See (https://github.com/talaia-labs/python-teos#state-of-the-project):
See also: 5f656a1 - Replaces python-teos by rust-teos