Add CI Checks for Kotlin #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexanderwiederin
commented
Nov 3, 2023
•
alexanderwiederin
commented
- Adds linting for non-generated Kotlin files
- Adds ability to run LDK-node-jvm tests against docker instances of bitcoind and electrs
- Adds a github workflow for Kotlin checks (excluding LDK-node-android lib generation)
alexanderwiederin
force-pushed
the
kotlin-lint
branch
2 times, most recently
from
0b3a940 to
8b58879
Compare
alexanderwiederin
force-pushed
the
kotlin-lint
branch
from
795fed0 to
a58f4f6
Compare
tnull
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Thanks for looking into this!
Already looks great, just a few comments/questions.
Also, more generally, could you try to clean up the git history and group fixups with the individual commits they are belonging to, so that they can eventually be squashed into the corresponding commits before merging?
bindings/kotlin/ldk-node-jvm/lib/src/test/kotlin/org/lightningdevkit/ldknode/LibraryTest.kt
Outdated
Show resolved
Hide resolved
bindings/kotlin/ldk-node-jvm/lib/src/test/kotlin/org/lightningdevkit/ldknode/LibraryTest.kt
Show resolved
Hide resolved
bindings/kotlin/ldk-node-jvm/lib/src/test/kotlin/org/lightningdevkit/ldknode/LibraryTest.kt
Outdated
Show resolved
Hide resolved
tnull
reviewed
Nov 7, 2023
alexanderwiederin
force-pushed
the
kotlin-lint
branch
6 times, most recently
from
f887082 to
d42683d
Compare
alexanderwiederin
force-pushed
the
kotlin-lint
branch
from
d42683d to
52c9694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.