Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vss client side encryption using StorableBuilder #225

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Add Vss client side encryption using StorableBuilder #225

merged 1 commit into from
Jan 8, 2024

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Jan 4, 2024

Add Vss client side encryption using StorableBuilder

@G8XSU G8XSU requested a review from tnull January 4, 2024 22:32
tnull
tnull reviewed Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, mostly looks good!

Cargo.toml Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/io/vss_store.rs Show resolved Hide resolved
src/io/vss_store.rs Show resolved Hide resolved
src/io/vss_store.rs Show resolved Hide resolved
@G8XSU G8XSU requested a review from tnull January 5, 2024 22:13
@G8XSU G8XSU mentioned this pull request Jan 6, 2024
Merged
tnull
tnull reviewed Jan 6, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mod one nit.

Feel free to squash fixups.

src/builder.rs Outdated Show resolved Hide resolved
tnull
tnull approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull tnull merged commit 860a1d5 into lightningdevkit:main Jan 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @tnull