Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade UniFFI to 0.26.0 #230

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Upgrade UniFFI to 0.26.0 #230

merged 3 commits into from
Feb 2, 2024

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Jan 24, 2024

.. which notably features support for async methods and non_exhaustive enums.

@tnull tnull mentioned this pull request Jan 24, 2024
Merged
@tnull tnull force-pushed the 2024-01-upgrade-uniffi-to-0.26 branch 3 times, most recently from 1610e94 to c58189e Compare January 24, 2024 12:30
@tnull
Upgrade UniFFI to 0.26.0
2761eef 
.. which features `async` support.

It also requires us to bump `jna` to 5.12 and the
`kotlinx-coroutines-core` test dependency to `1.6.4`.
@tnull tnull force-pushed the 2024-01-upgrade-uniffi-to-0.26 branch from c58189e to 735a38f Compare January 24, 2024 12:48
tnull added 2 commits January 24, 2024 14:15
@tnull
Use SystemCleaner on Android
3345ade 
We use Android's `SystemCleaner` when available, which should increase
overall GC performance.

See description here: https://developer.android.com/reference/android/system/SystemCleaner
@tnull
Drop Network newtype again
9026795 
We previously (re-)introduced a newtype with the most-recent
`rust-bitcoin` update as it added the `non_exhaustive` attribute to the
`Network` enum.

However, we can now drop this newtype again as UniFFI 0.26.0 added
support for `non_exhaustive` enums.
@tnull tnull force-pushed the 2024-01-upgrade-uniffi-to-0.26 branch from 735a38f to 9026795 Compare January 24, 2024 13:19
@tnull tnull mentioned this pull request Jan 24, 2024
Merged
@thunderbiscuit
Copy link

Hey thanks for pointing out to us that you were doing the upgrade!

Question for ya: do you know if the uniffi-android.toml file now called by the --config flag simply adds to the configurations already defined in uniffi.toml, or if it becomes the only configurations read by the build process?

@tnull
Copy link
Collaborator Author

tnull commented Jan 25, 2024

Hey thanks for pointing out to us that you were doing the upgrade!

Question for ya: do you know if the uniffi-android.toml file now called by the --config flag simply adds to the configurations already defined in uniffi.toml, or if it becomes the only configurations read by the build process?

It's additive, see https://mozilla.github.io/uniffi-rs/bindings.html#customizing-the-binding-generation:

--config option can be used to specify additional uniffi config file. This config is merged with the uniffi.toml config present in each crate, with its values taking precedence.

@thunderbiscuit
Copy link

Oh thanks! They keep adding pages and I try to make sure I see all the new ones but totally missed that. 👍

@tnull tnull mentioned this pull request Feb 2, 2024
Closed
@tnull
Copy link
Collaborator Author

tnull commented Feb 2, 2024 •
edited
Loading

Going ahead and merging this.

@tnull tnull merged commit e335f0b into lightningdevkit:main Feb 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnull @thunderbiscuit