Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UniFFI to 0.27.3 #379

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Oct 16, 2024

We bump our uniffi dependencies to 0.27.3 to get the newer features (mostly async trait support, really).

We don't go to 0.28 directly since it breaks our Swift build process (I kinda assume we'll have to switch to the newly introduced uniffi-bingend-swift binary, but we'll see).

@tnull tnull requested a review from G8XSU October 16, 2024 09:28
@tnull tnull force-pushed the 2024-10-upgrade-uniffi branch 3 times, most recently from 809bccc to 4aaa01d Compare October 16, 2024 10:16
@tnull tnull changed the title Upgrade UniFFI Upgrade UniFFI to 0.27.3 Oct 16, 2024
G8XSU
G8XSU previously approved these changes Oct 16, 2024
Copy link
Contributor

@G8XSU G8XSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes and lgtm!

@G8XSU
Copy link
Contributor

G8XSU commented Oct 16, 2024

Need to resolve conflict!

@tnull
Copy link
Collaborator Author

tnull commented Oct 16, 2024

Need to resolve conflict!

Rebased to resolve minor conflict.

@tnull tnull merged commit 137bfff into lightningdevkit:main Oct 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants