Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recoverloopin: Sqlite option #113

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

sputn1ck
Copy link
Member

This PR allows recoverloopin to use the sqlite db.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thank you very much!
Just a couple of nits and user experience comments, otherwise looks great 🎉

cmd/chantools/recoverloopin.go Show resolved Hide resolved
cmd/chantools/recoverloopin.go Show resolved Hide resolved
cmd/chantools/recoverloopin.go Outdated Show resolved Hide resolved
cmd/chantools/recoverloopin.go Outdated Show resolved Hide resolved
@sputn1ck sputn1ck force-pushed the recoverloopin_sqlite branch from 551a8e2 to a7fdad5 Compare January 12, 2024 10:07
@sputn1ck sputn1ck requested a review from guggero January 12, 2024 10:08
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close, just one more thing...

cmd/chantools/recoverloopin.go Show resolved Hide resolved
cmd/chantools/recoverloopin.go Show resolved Hide resolved
cmd/chantools/recoverloopin.go Outdated Show resolved Hide resolved
@sputn1ck sputn1ck force-pushed the recoverloopin_sqlite branch 2 times, most recently from fbdf950 to 420db91 Compare January 12, 2024 10:37
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM 🎉

@guggero
Copy link
Member

guggero commented Mar 27, 2024

Needs a rebase.

@guggero guggero force-pushed the recoverloopin_sqlite branch from 420db91 to 6510903 Compare March 27, 2024 17:37
This commit will allow to recover loop ins that have been made with
sqlite.
@guggero guggero force-pushed the recoverloopin_sqlite branch from 6510903 to 3e419da Compare March 27, 2024 17:43
@guggero guggero merged commit 676ba60 into lightninglabs:master Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants