Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage 2 major review #17

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Stage 2 major review #17

wants to merge 7 commits into from

Conversation

magomimmo
Copy link
Contributor

I wrote a major review of the stage 2 tutorial, the one on lncli-web.

@magomimmo
Copy link
Contributor Author

magomimmo commented Dec 28, 2017 •
edited
Loading

Just take into account that the stage 1 included in this PR is still the one in your master and not the PR I pushed yesterday.

@ndeet
Copy link
Contributor

ndeet commented Dec 29, 2017

Hi, I'm no maintainer here but two things:

@magomimmo
Copy link
Contributor Author

@ndeet you're totally right. My fault. Sorry about that. My only excuse is that this a text repository, not a code repository, but you're right anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magomimmo @ndeet @MaxFangX