Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod+poolscript: bump lnd compile time dependency to v0.18.4-beta #488

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Sep 18, 2024

Depends on lightningnetwork/lnd#8960.
Depends on lightninglabs/lndclient#192.

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

This commit prepares for a change in lndclient, where each sub server
client needs to implement a specific method.
Because of that requirement we cannot have a single mock that implements
two of those methods and we need to split the wallet and signer mocks
apart.
@guggero
Copy link
Member Author

guggero commented Oct 14, 2024

Bumped to lndclient v0.18.4-0 which references lightningnetwork/lnd#9183 (commit lightningnetwork/lnd@ca3bde9) which should remain stable.

@guggero guggero marked this pull request as ready for review October 14, 2024 14:45
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero guggero merged commit e5a3f38 into master Oct 15, 2024
6 checks passed
@guggero guggero deleted the update-to-lnd-18-4 branch October 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants