tapdb: fix performance of aggregate stats #1310
Open
+228
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cleans up and fixes a couple of things in the universe index performance test: 1. More compact formatting for some of the queries. 2. Update index name, was incorrect before. 3. Add context to where the individual queries come from. 4. Allow specific sub tests to be run.
guggero
force-pushed
the
aggregate-stats-performance
branch
from
eac021b to
fa0d45b
Compare
Pull Request Test Coverage Report for Build 12871932746Details
💛 - Coveralls |
jbrill
approved these changes
Jan 20, 2025
| @@ -0,0 +1,2 @@ | |||
| -- This file is empty on purpose. There is nothing to roll back for this | |||
| -- migration. | |||
There was a problem hiding this comment.
Do we not want to restore the old universe_view in this rollback?
| FROM aggregated ag | ||
| JOIN universe_roots roots | ||
| ON ag.universe_root_id = roots.id | ||
| GROUP BY roots.asset_id, roots.group_key, roots.proof_type |
There was a problem hiding this comment.
Should we not tweak the index here like in the test?
CREATE INDEX IF NOT EXISTS idx_universe_leaves_asset
ON universe_leaves(
asset_genesis_id, universe_root_id
);`
There was a problem hiding this comment.
Same with idx_mssmt_nodes_composite
| numQueries = 100 * longTestScale | ||
| numAssets = 100 * longTestScale | ||
| numLeavesPerTree = 300 * longTestScale | ||
| numQueries = 100 * longTestScale |
There was a problem hiding this comment.
Should the test timeout be a bit longer for the _long_test.go or do you think the 5 minute timeout is ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #1302.
Difference can best be seen when running
make unit-trace pkg=tapdb long-tests=1 case=TestUniverseIndexPerformance/name=query_aggregated:I also confirmed on mainnet that the old and new query return the exact same result:
old-query.txt
new-query.txt
The speedup on mainnet is also quite significant. The old query took 2.5 minutes while the new one only took 15 seconds.
Hopefully this should make #1302 not necessary (but let's keep it anyway, since it's a good idea as well).
Shout out to @jbrill who's performance test setup allowed me to test this quite easily.