Linter checks go versions in Dockerfile and YAML files #8211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
changed the title
guggero
reviewed
Dec 8, 2023
| local required_go_version="$2" | ||
|
|
||
| # Use grep to find lines with 'go:' | ||
| local go_lines=$(grep -i '^\s*go:\s*"[0-9]\+\.[0-9]\+\.[0-9]\+"' "$yamlfile" || true) # Ignore grep exit status |
There was a problem hiding this comment.
nit: move comment to before the line to not make it even longer?
|
@ffranr, remember to re-request review from reviewers when ready |
|
Closing due to inactivity |
4 similar comments
|
Closing due to inactivity |
|
Closing due to inactivity |
|
Closing due to inactivity |
|
Closing due to inactivity |
|
following the orders of the bot 🤓 feel free to re-open! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR adds two checks to the linter. These checks ensure that the Go version used in Dockerfile files and YAML files are consistent and as expected.
Steps to Test
Check to ensure that the CI linter Go version check output is correct.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.