-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod: bump neutrino to testing version #8797
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@djkazic - maybe keep an eye here and retrigger the neutrino test run till it succeeds? (or have a look to see if the reason it is failing is due to the latest changes) |
I think it's just the coverage test that fails. But I'm not sure why. I could try retriggering it though. |
ah! indeed - my bad. no need to re-trigger that imo - it's a static check afaiaa |
@djkazic - mind just rebasing on master - a fix was pushed last week that should remove the flake that has been occuring in the neutrino test (which it turns out isnt just a coverage test) |
b659b63
to
52057c7
Compare
This is the sister PR to the neutrino PR here: lightninglabs/neutrino#300