Beat [3/4]: prepare resolvers to handle the blockbeat #8922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
be50d50 to
5d8ea80
Compare
yyforyongyu
force-pushed
the
yy-blockbeat
branch
2 times, most recently
from
7b05026 to
d76a26e
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
5d8ea80 to
e568154
Compare
yyforyongyu
force-pushed
the
yy-blockbeat
branch
from
d76a26e to
4e00941
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
e568154 to
0ab9846
Compare
yyforyongyu
force-pushed
the
yy-blockbeat
branch
2 times, most recently
from
7b1b444 to
d900f98
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
0ab9846 to
a5d0e99
Compare
yyforyongyu
force-pushed
the
yy-blockbeat
branch
7 times, most recently
from
45b97aa to
4359f45
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
a5d0e99 to
550ffbe
Compare
yyforyongyu
force-pushed
the
yy-blockbeat
branch
6 times, most recently
from
032866b to
103f551
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
2 times, most recently
from
b340b4c to
d620291
Compare
yyforyongyu
changed the title
Consumer on chainWatcher and resolvers
yyforyongyu
force-pushed
the
yy-blockbeat
branch
from
5a4ccc8 to
5236a0e
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
d620291 to
6819393
Compare
yyforyongyu
force-pushed
the
yy-blockbeat
branch
from
5236a0e to
24f208b
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
6819393 to
2bdbe76
Compare
yyforyongyu
force-pushed
the
yy-blockbeat
branch
2 times, most recently
from
3674ed3 to
737b0a0
Compare
We now put the outpoint in the resolvers's logging so it's easier to debug. Also use the short channel ID whenever possible to shorten the log line length.
This commit adds a few helper methods to decide how the htlc output should be spent.
This commit is a pure refactor in which moves the sweep handling logic into the new methods.
This commit refactors the `Resolve` method by adding two resolver handlers to handle waiting for spending confirmations.
This commit adds new methods to handle making sweep requests based on the spending path used by the outgoing htlc output.
This commit adds checkpoint methods in `htlcTimeoutResolver`, which are similar to those used in `htlcSuccessResolver`.
This commit adds more methods to handle resolving the spending of the output based on different spending paths.
We will use this and its following commits to break the original `Resolve` methods into two parts - the first part is moved to a new method `Launch`, which handles sending a sweep request to the sweeper. The second part remains in `Resolve`, which is mainly waiting for a spending tx. Breach resolver currently doesn't do anything in its `Launch` since the sweeping of justice outputs are not handled by the sweeper yet.
This commit breaks the `Resolve` into two parts - the first part is moved into a `Launch` method that handles sending sweep requests, and the second part remains in `Resolve` which handles waiting for the spend. Since we are using both utxo nursery and sweeper at the same time, to make sure this change doesn't break the existing behavior, we implement the `Launch` as following, - zero-fee htlc - handled by the sweeper - direct output from the remote commit - handled by the sweeper - legacy htlc - handled by the utxo nursery
This commit breaks the `Resolve` into two parts - the first part is moved into a `Launch` method that handles sending sweep requests, and the second part remains in `Resolve` which handles waiting for the spend. Since we are using both utxo nursery and sweeper at the same time, to make sure this change doesn't break the existing behavior, we implement the `Launch` as following, - zero-fee htlc - handled by the sweeper - direct output from the remote commit - handled by the sweeper - legacy htlc - handled by the utxo nursery
A minor refactor is done to support implementing `Launch`.
This commit makes `resolved` an atomic bool to avoid data race. This field is now defined in `contractResolverKit` to avoid code duplication.
In this commit, we break the old `launchResolvers` into two steps - step one is to launch the resolvers synchronously, and step two is to actually waiting for the resolvers to be resolved. This is critical as in the following commit we will require the resolvers to be launched at the same blockbeat when a force close event is sent by the chain watcher.
yyforyongyu
force-pushed
the
yy-blockbeat-finalize
branch
from
2bdbe76 to
f9deab4
Compare
yyforyongyu
merged commit f9deab4
into
lightningnetwork:yy-blockbeat
8 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8894
NOTE: itest is fixed in the final PR #9227.
WIP: don't review it yet (created to check CI).
Turns out mounting
blockbeatinChannelArbitratorcan be quite challenging (unit tests, itest, etc). This PR attempts to implement it in hopefully the least disruptive way - onlychainWatcherimplementsConsumer, and the contract resolvers are kept stateless (in terms of blocks). The main changes are,Resolvemethod is broken into two steps: 1)Launchthe resolver, which handles sending the sweep request, and 2)Resolvethe resolver, which handles monitoring the spending of the output.chainWatchernow implementsConsumer.Alternatives
The original attempt is to make the resolvers subscribe to a blockbeat chan, as implemented in #8717. The second attempt is to make the resolvers also blockbeat
Consumer, as implemented here.This third approach is chosen as 1) it greatly limits the scope otherwise a bigger refactor of channel arbitrator may be needed, and 2) the resolvers can be made stateless in terms of blocks, and be fully managed by the channel arbitrator. In other words, when a new block arrives, the channel arbitrator decides whether to launch the resolvers or not, so the resolvers themselves don't need this block info.
In fact, there are only two resolvers that subscribe to blocks, the incoming contest resolver, which uses block height to decide whether to give up resolving an expired incoming htlc; and the outgoing contest resolver, which uses the block height to choose to transform itself into a timeout resolver. IMO if we can remove the inheritance pattern used in
contest resolver -> time/success resolverand manage to transform resolvers in channel arbitrator, we can further remove those two block subscriptions. As for now, we can leave them there as they have little impact on the block consumption order enforced by the blockbeat.