lint

Signed-off-by: liguozhong <[email protected]> Signed-off-by: fuling <[email protected]>
liguozhong · Oct 19, 2023 · 1e992f7 · 1e992f7
1 parent 2921857
commit 1e992f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/notifier/notifier.go b/notifier/notifier.go
@@ -625,11 +625,8 @@ func (a alertmanagerLabels) url() *url.URL {
 		Path:   a.labels.Get(pathLabel),
 	}
 }
-func NewTarget(labels labels.Labels, discoveredLabels labels.Labels) *Target {
-	return &Target{
-		labels:           labels,
-		discoveredLabels: discoveredLabels,
-	}
+func NewTarget(labels labels.Labels, discoveredLabels labels.Labels) Target {
+	return Target{labels, discoveredLabels}
 }
 
 type Target struct {

diff --git a/web/api/v1/api_test.go b/web/api/v1/api_test.go
@@ -230,7 +230,7 @@ func (t testAlertmanagerRetriever) TargetsAll() map[string][]notifier.Target {
 	allTargets := make(map[string][]notifier.Target)
 
 	allTargets["prod"] = []notifier.Target{
-		*notifier.NewTarget(
+		notifier.NewTarget(
 			labels.FromMap(map[string]string{
 				model.SchemeLabel:  "http",
 				model.AddressLabel: "http://alertmanager.example.com:8080",
@@ -246,7 +246,7 @@ func (t testAlertmanagerRetriever) TargetsAll() map[string][]notifier.Target {
 	}
 
 	allTargets["dev"] = []notifier.Target{
-		*notifier.NewTarget(
+		notifier.NewTarget(
 			labels.EmptyLabels(),
 			labels.FromMap(map[string]string{
 				model.SchemeLabel:  "http",