Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: list resource templates #821

Merged
merged 18 commits into from
Jan 13, 2025
Merged

feature: list resource templates #821

merged 18 commits into from
Jan 13, 2025

Conversation

llorentelemmc
Copy link
Contributor

@llorentelemmc llorentelemmc commented Jan 6, 2025

As opposed to functions, there are no supertype templates: If a template is created on the parent resource type, it is not visible in the child resource type.

@llorentelemmc llorentelemmc self-assigned this Jan 6, 2025
@llorentelemmc llorentelemmc changed the base branch from master to development January 6, 2025 13:37
@llorentelemmc llorentelemmc deleted the branch development January 9, 2025 12:37
@llorentelemmc llorentelemmc reopened this Jan 9, 2025
@llorentelemmc llorentelemmc marked this pull request as ready for review January 9, 2025 16:04
canOverwrite: false,
},
]);

add() {
Copy link
Contributor

@BeriBoss BeriBoss Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused methods add, edit, delete, overwrite

canOverwrite: false,
},
]);

add() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused methods add, edit, delete, overwrite

Copy link
Contributor

@BeriBoss BeriBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the unused methods have been removed, it can be merged.

permissions = computed(() => {
if (this.authService.restrictions().length > 0 && this.resourceType()) {
return {
canShowSuperTypeTemplates: this.authService.hasPermission(RESOURCETYPE_PERM, Action.READ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename to canShowTypeTemplates

@llorentelemmc llorentelemmc merged commit 5e7e672 into development Jan 13, 2025
1 check passed
@llorentelemmc llorentelemmc deleted the list-templates branch January 14, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants