Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info on limit for OhDear #293

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

Chris53897
Copy link
Contributor

@kbond kbond merged commit 5c4f771 into liip:3.x Feb 18, 2024
13 checks passed
@Chris53897 Chris53897 deleted the feature/readme-oh-dear branch February 18, 2024 15:29
@kbond
Copy link
Collaborator

kbond commented Feb 18, 2024

Should we hard code the results limit to 50 so at least the first 50 run?

@Chris53897
Copy link
Contributor Author

Good idea. But OhDear can change this limit anytime.

@kbond
Copy link
Collaborator

kbond commented Feb 18, 2024

Yeah that's true but right now, none run, correct? I guess we'll just need to update as required...

@kbond
Copy link
Collaborator

kbond commented Feb 18, 2024

Did you hit this limit?

@kbond
Copy link
Collaborator

kbond commented Feb 18, 2024

The alternative would be to throw an exception I guess. Force users to add to a suite that's size is less than 50. I'd be fine with that also.

@Chris53897
Copy link
Contributor Author

For now i would suggest to leave it as it is. As there are more important other tasks for me personally.
I do not hit this limit.

@kbond
Copy link
Collaborator

kbond commented Feb 18, 2024

Fine by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants