Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big ol' route restructure #116

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Big ol' route restructure #116

merged 2 commits into from
Aug 29, 2024

Conversation

tom-sherman
Copy link
Contributor

@tom-sherman tom-sherman commented Aug 29, 2024

Moving from /at?u=at://{did}/{collection}/{rkey} to /at/{did}/{collection}/{rkey}.

The old route still exists and redirects to the new one. The query string is helpful because sometimes you have an at uri and just want to open it quickly, can just append it to atproto-browser.vercel.app/at?u= but the separate routes give us greater performance through layout sharing and caching, they also help with code organisation.

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atproto-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:30pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
frontpage ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 3:30pm
unravel ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 3:30pm

@tom-sherman tom-sherman merged commit 936c332 into main Aug 29, 2024
5 checks passed
@tom-sherman tom-sherman deleted the atpb-route-refactor branch August 29, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant