Improve post list perf #136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tom-sherman
commented
Oct 6, 2024
| return null; | ||
| } | ||
|
|
||
| const plcDoc = await getDidDoc(did); |
There was a problem hiding this comment.
There are still a bunch of extra cache reads coming from calling getDidDoc inside getVerifiedHandle...
I think the best thing to do would be to move to a resolveIdentity function like we do in atproto-browser - a function that accepts a handle or a DID and returns the did along with the did doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is mainly to reduce cache reads. All of the reads that I'm reducing should be happening in parallel pretty much (either via
.map()or suspense or both. But looks like Vercel data cache gets pretty slow with many parallel reads.