Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications #192

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Notifications #192

merged 6 commits into from
Nov 6, 2024

Conversation

tom-sherman
Copy link
Contributor

@tom-sherman tom-sherman commented Nov 3, 2024

Depends on #191.

Some previous discussion on #155

image image

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 10:39pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
atproto-browser ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 10:39pm
unravel ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 10:39pm

@JakeSaterlay
Copy link
Contributor

Wonder if "Mark All As Read" should be disabled if there are no notifications, and/or if they are all read?

Could be something that we add after this though, as it could be a bit more complicated calculating this if we just wanna get it out

Copy link
Collaborator

@WillCorrigan WillCorrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add indexing for notifications on notification id/user did too

packages/frontpage/lib/data/db/notification.ts Outdated Show resolved Hide resolved
WillCorrigan
WillCorrigan previously approved these changes Nov 5, 2024
@tom-sherman tom-sherman merged commit 28d3798 into main Nov 6, 2024
8 checks passed
@tom-sherman tom-sherman deleted the un-77-notifications-part-2 branch November 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants