Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling previews #204

Closed
wants to merge 13 commits into from
Closed

styling previews #204

wants to merge 13 commits into from

Conversation

damiensedgwick
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
If you are adding a new feature, please discuss it beforehand by opening a discussion.

Does this fix an issue? If so:
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 6:15pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
atproto-browser ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 6:15pm
unravel ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 6:15pm

@damiensedgwick
Copy link
Contributor Author

Check all pages for mobile. One of the comment thread views does not have the correct padding.

@damiensedgwick
Copy link
Contributor Author

When we load in more posts via scrolling, the new element is not a part of the original posts list so it is an element on it's own and therefor it is missing the divide-y style.

This needs fixing.

@damiensedgwick
Copy link
Contributor Author

Too much all at once. Focus on cards and then on layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant