Add OS to lima.yaml for future guests #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid hardcoding "linux" everywhere, use OS instead (like Arch). TODO: Add proper cidata template parameter for LIMA_CIDATA_HOME Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
limayaml-os-linux
branch
from
5762a8a to
ce1ea79
Compare
|
Home directory parameter here: |
cdfmlr
added a commit
to cdfmlr/lima
that referenced
this pull request
Aug 31, 2023
This commit fix lima-vm#1768 by: 1. add `"OS"` to the know list since lima-vm#1735 introduced this field. 2. make the log message more clear: `Ignoring: vmType vz: [...]` -> `Ignoring following configuration due to the use of vmType vz: [...]`
cdfmlr
added a commit
to cdfmlr/lima
that referenced
this pull request
Aug 31, 2023
This commit fix lima-vm#1768 by: 1. add `"OS"` to the know list since lima-vm#1735 introduced this field. 2. make the log message more clear: `Ignoring: vmType vz: [...]` -> `Ignoring following configuration due to the use of vmType vz: [...]` Signed-off-by: Yuehchan Chueng <[email protected]>
cdfmlr
added a commit
to cdfmlr/lima
that referenced
this pull request
Aug 31, 2023
This commit fix lima-vm#1768 by: 1. add `"OS"` to the know list since lima-vm#1735 introduced this field. 2. make the log message more clear: `Ignoring: vmType vz: [...]` -> `Ignoring following configuration due to the use of vmType vz: [...]` Signed-off-by: CDFMLR <[email protected]>
cdfmlr
added a commit
to cdfmlr/lima
that referenced
this pull request
Sep 11, 2023
This commit fix lima-vm#1768 by: 1. add `"OS"` to the know list since lima-vm#1735 introduced this field. 2. make the log message clear: `Ignoring: vmType vz: [...]` -> `vmType vz: ignoring ...` Signed-off-by: CDFMLR <[email protected]>
DennisRasey
pushed a commit
to DennisRasey/lima
that referenced
this pull request
Jan 11, 2024
This commit fix lima-vm#1768 by: 1. add `"OS"` to the know list since lima-vm#1735 introduced this field. 2. make the log message clear: `Ignoring: vmType vz: [...]` -> `vmType vz: ignoring ...` Signed-off-by: CDFMLR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid hardcoding "linux" everywhere, use OS instead (like Arch).
TODO: Add proper cidata template parameter for LIMA_CIDATA_HOMEThere are some other hardcoded Linux or Systemd specific things too:
/bin/bashor/run, those are not addressed here and are left as is.Doing the OS refactoring in a separate PR, makes it easier to add OS