Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up gvisor-tap-vsock #2629

Closed
wants to merge 1 commit into from
Closed

Conversation

fatanugraha
Copy link

Fixes #2585

Confirmed by running the reproduction steps in the linked issue

this PR (a6ff968):

2024-09-18 22:30:42.245933545 +0800 +08 m=+0.000158546 starting LookupIP
LocalAddr:  192.168.5.1:50406
ok
2024-09-18 22:32:17.372494481 +0800 +08 m=+95.126719566 starting LookupIP
LocalAddr:  192.168.5.1:50406
ok

master (4c687f7):

LocalAddr:  192.168.5.1:50406
ok
2024-09-18 22:38:03.812625673 +0800 +08 m=+95.112963461 starting LookupIP
LocalAddr:  192.168.5.1:50406
LocalAddr:  192.168.5.1:50406
err lookup www.google.com on 127.0.0.53:53: read udp 192.168.5.1:50406->8.8.8.8:53: i/o timeout

@fatanugraha fatanugraha changed the title Bump up gvisor-tap-proxy Bump up gvisor-tap-vsock Sep 18, 2024
@jandubois
Copy link
Member

I notice the bump is to a commit, not a new release. Should we not wait at least a week or two to see if there is a new upstream release with this change?

We normally only bump to a commit when upstream doesn't release anymore:

$ grep -E 'v\d+\.\d+\.\d+-' go.mod | grep -v indirect | grep -v v0.0.0
	github.com/sirupsen/logrus v1.9.4-0.20230606125235-dd1b4c2e81af
	gopkg.in/op/go-logging.v1 v1.0.0-20160211212156-b2cb9fa56473

@fatanugraha
Copy link
Author

Sure i think we can wait. I’m going to close this PR in favor of dependabot’s future PR, i will follow this issue up there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropped DNS/UDP requests on user-v2 network
2 participants