TW-2145: Update condition for mapping formatted_body

doc/adr/0003-improve-get-event-content-from-message-text.md

@@ -0,0 +1,24 @@
+# 3. 0003-improve-get-event-content-from-message-text.md
+
+Date: 2024-12-08
+
+## Status
+
+Accepted
+
+## Context
+
+- The current implementation includes parsing the message for markdown, converting line breaks, and
+  formatting the message if necessary.
+
+## Decision
+
+- We will refactor the getEventContentFromMsgText function to improve its readability and structure.
+  The changes include:
+    1. Extracting the markdown conversion logic into a separate function.
+    2. Simplifying the line break conversion and formatting check.
+
+## Consequences
+
+- The function will be easier to read and maintain.
+- The logic for markdown conversion and line break handling will be more modular and reusable

lib/src/room.dart

@@ -646,14 +646,13 @@ class Room {
           threadRootEventId: threadRootEventId,
           threadLastEventId: threadLastEventId);
     }
-    
+
     final eventContent = getEventContentFromMsgText(
       message: message,
       parseMarkdown: parseMarkdown,
       msgtype: msgtype,
     );
-    return sendEvent(
-        eventContent,
+    return sendEvent(eventContent,
         txid: txid,
         inReplyTo: inReplyTo,
         editEventId: editEventId,
@@ -674,9 +673,17 @@ class Room {
       final html = markdown(event['body'],
           getEmotePacks: () => getImagePacksFlat(ImagePackUsage.emoticon),
           getMention: getMention);
+
+      final formatText = event['body']
+          .toString()
+          .trim()
+          .replaceAll(RegExp(r'(<br />)+$'), '')
+          .convertLinebreaksToBr()
+          .replaceAll(RegExp(r'<br />\n?'), '\n');
+
       // if the decoded html is the same as the body, there is no need in sending a formatted message
       if (HtmlUnescape().convert(html.replaceAll(RegExp(r'<br />\n?'), '\n')) !=
-          event['body']) {
+          formatText) {
         event['format'] = 'org.matrix.custom.html';
         event['formatted_body'] = html;
       }

lib/src/utils/markdown.dart

@@ -263,7 +263,7 @@ String markdown(
   return ret;
 }
 
-extension on String {
+extension StringExtension on String {
   String convertLinebreaksToBr() {
     final parts = split('pre>');
     var convertLinebreaks = true;