TF-3275 Fix FCM iOS foreground desync #3314
Open
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dab246
reviewed
Dec 2, 2024
dab246
reviewed
Dec 2, 2024
| @@ -143,6 +145,7 @@ class NotificationService: UNNotificationServiceExtension { | |||
| self.modifiedContent?.body = message | |||
| self.modifiedContent?.badge = NSNumber(value: 1) | |||
| self.modifiedContent?.sound = .default | |||
| self.modifiedContent?.userInfo = ["data": originalContent.userInfo] | |||
There was a problem hiding this comment.
onMessage of FCM Flutter is using data key for its payload.
dab246
reviewed
Dec 2, 2024
Comment on lines
161
to
163
| var combinedUserInfo = userInfo | ||
| combinedUserInfo["data"] = originalContent.userInfo | ||
| self.modifiedContent?.userInfo = combinedUserInfo |
There was a problem hiding this comment.
Also please test notification on onBackground
There was a problem hiding this comment.
FCM background is not affected
dab246
reviewed
Dec 2, 2024
|
Screen.Recording.2024-12-02.at.16.11.56.mov
|
|
did you tested with iOS v18.* @tddang-linagora |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Root cause
mutable-content: trueResolved
Screen.Recording.2024-11-28.at.14.55.12.mov