TW-1787: Improve when leave chat #1842

hieutbui · 2024-05-31T14:58:55Z

Ticket

[UI/UX] Improve when leave group chat #1787

Root cause

Right now, close context menu function and context menu actions function are called parallel -> for actions that show loading dialog, the expected behavior will not work

Solution

Move UI of actions item into context menu widget
Call actions function after close function

Resolved

Web:

context.menu.web.mp4

img.player.web.mp4

Android:

android.mp4

img.player.android.mp4

github-actions · 2024-05-31T15:09:10Z

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1842

sherlockvn · 2024-06-03T03:09:48Z

Can you test again with mobile platform. I will help you test in mobile IOS

hieutbui · 2024-06-03T03:27:40Z

Can you test again with mobile platform. I will help you test in mobile IOS

I updated the video for android.

sherlockvn · 2024-06-03T04:16:53Z

Work well in case of IOS:

RPReplay_Final1717388154.MP4

nqhhdev · 2024-06-03T04:17:05Z

I found issues related to delete avt in Profile

Reproduce steps:

Go to profile
Click on edit profile and choose delete avatar
Show loading dialog and pop previous screen

Screen.Recording.2024-06-03.at.11.09.21.mov

IMO: When delete avatar success, still on profile

lib/widgets/context_menu/context_menu_action.dart

nqhhdev · 2024-06-03T04:18:43Z

Test

Web

Context menu in Chat list
- Pin/unpin
- Read/unread
- Mute/unmute
Context menu in Chat
- Select/unselect
- Copy
- Pin/unpin
- Forward
- Leave chat
Context menu in Pin screen
- Unpin
- Select/unselect
- Jump
- Copy
- Forward

Mobile

Context menu in Chat
- Leave
- Message info
- Report message

I built local and github link and tested it. Works well on my side

lib/widgets/mixins/twake_context_menu_mixin.dart

nqhhdev · 2024-06-03T05:18:51Z

Pls help me test case on mobile/web:

Open image player and use context menu (Save file, show in chat) on it

hieutbui · 2024-06-04T04:10:41Z

Pls help me test case on mobile/web:

Open image player and use context menu (Save file, show in chat) on it

Demo videos updated!

lib/widgets/mixins/twake_context_menu_mixin.dart

lib/widgets/context_menu/twake_context_menu.dart

Te-Z · 2024-06-06T13:42:44Z

Hi @hieutbui can you rebase this branch please ?

hieutbui · 2024-06-07T02:44:04Z

Hi @hieutbui can you rebase this branch please ?

done!

nqhhdev

LGTM

* TW-1787: Move UI of action items into context menu widget * TW-1787: Update context menu for chat screen * TW-1787: Update context menu for chat list * TW-1787: Update context menu for pinned screen

* TW-1772: Prevent infinity contact loop * TW-1772: Show recent contact in contact tab * TW-1772: Showing no contact in new chat screen * TW-1772: Showing no contact in new group chat screen * TW-1773: review load 0 more participants * TW-1773: listen for roomMember change in chat details * TW-1735: search external contact widget added on search view * TW-1735: update matrix dart sdk * TW-1780: Open screen can connect with Twake Workplace when add another account * TW-1780: Add `app=chat` to parameter whenever call to signup in TWP * TW-1785: Improve logout for multiple homeserver (#1788) * Bump version to v2.5.4 * Update privacy welcome screen * TW-1526: Fix Cannot unmute more than 2 chats at the same time * Bump version to v2.5.5 * TW-1781: change the ci/cd to use flutter 3.22 * TW-1781: remove warning based on new lint version * TW-1781: remove deprecated change to have new change * TW-1781: fix the ci issue * TW-1781: add deprecated and TODO for background and onBackground color * TW-1781 Fix ci failed * Bump version to v2.5.8 * TW-1645: Add counting selected image at send icon (#1803) * TW-1645: Add counting selected image at send icon * TW-1645: Add style file for `media_picker_mixin` * TW-1645: Fix size for counter icon (#1816) * TW-1615: Support auto jump to lastest message when user send an attachments (#1810) * TW-1615: Support auto jump to lastest message when user send an attachment * TW-1615: Support auto jump to lastest message when use copy/paste * hot-fix: members list always have to reload (#1801) * TW-1793: recent chats are not recent (#1800) * hot-fix: fix the index.html loading failed * TW-1356: change action for profile tap * TW-1356: update UI for multiple accounts in setting profile * TW-1356: fix multiple accout with same homeserver can login * TW-1356: fix the avatar not updated when app terminated * hot-fix: fix the problem with index.html file * TW-1635: remove the messages contains reply from search result (#1819) * Switched runners to macos-latest (#1820) * Update metadata to config store kit (#1843) * TW-1698: Add minWidth for group details (#1809) * hot-fix: fix the error l10n not found after build runner build (#1855) * TW-1841: Fix back screen when use go_router and navigator (#1850) * Removed xcbeautify installation because it's preinstalled on runners (#1865) * TW-1787: Improve when leave chat (#1842) * TW-1787: Move UI of action items into context menu widget * TW-1787: Update context menu for chat screen * TW-1787: Update context menu for chat list * TW-1787: Update context menu for pinned screen * TW-1812 Remove X from the search bar when it's empty (#1852) * TW-1812 Remove X from the search bar when it's empty * fixup! TW-1812 Remove X from the search bar when it's empty * README.md Updated picture as management asked to do * Update Feature Graphic for fastlane metadata * Improve tom bootstrap dialog (#979) * Create init client dialog on mobile * Implement new bootstrap dialog for mobile * Implement new on auth screen for web * Prevent back button and back android during loading in homeserver picker * Fix dialog overlap when resizing screen * Fix dialog overlap when resizing screen * Handle error for `_getRecoveryWords` * Handle error for Twake welcome screen * TW-1644: allow access to the gallery is not center (#1815) * TW-1644: allow access to the gallery is not center * TW-1644: close the bottomsheet when go to settings * TW-1644: update style for image picker * TW-1602: when typing shift ctrl, the cursor is dissappear (#1853) * TW-1825: Copy/paste not work in search screen (#1874) * TW-1825: Fix search results aren't displayed correctly when copy/paste * TW-1825: Write unit test for this case * TW-1791: Improve display contacts on multiple homeserver (#1857) * TW-1791: Refresh contacts when switch another account or login new account * TW-1791: Write unit test for this case * TW-1791: Refresh contacts when login or logout * TW-1791: Fix missing `setUpToMServices` when switch account * TW-1836: Move shared media to direct chat profile (#1856) * TW-1836: Add shared media tabs into chat profile * TW-1836: Delete Shared media screen * TW-1836: Update `chat_details` * TW-1869: can not open keyboard when tap on the textfield in IOS (#1877) * Pinned Nix version to 2.22.1 to fix broken build (#1884) Also bumped olm to 3.2.16 * TW-1806: fix image weird display on web (#1866) * TW-1806: add support mime files for web platform, and util method to getTwake supported mimeType * TW-1806: make image have width and height when the error image when display * TW-1806: update mime type when drag/drop, paste and add file * TW-1806: fix wrong display when send HEIC file in android * TW-1806: display avif file in web * TW-1806: if image viewer can't be display by real image, use thumbnail * Tw 1750/improve when upload video (#1875) * TW-1750: add metadate when sending file event * TW-1750: fix typo error int videoMimeTypes * TW-1587: Fix can't open chat when click on notification (#1867) * TW-1777: Changing greeting message: include tag in greeting message (#1881) * Bump version to 2.5.9 --------- Co-authored-by: HuyNguyen <[email protected]> Co-authored-by: --global <[email protected]> Co-authored-by: Dat PHAM HOANG <[email protected]> Co-authored-by: sherlock <[email protected]> Co-authored-by: Nguyen Thai <[email protected]> Co-authored-by: Bùi Trung Hiếu <[email protected]> Co-authored-by: KhaledNjim <[email protected]> Co-authored-by: artembru <[email protected]>

hieutbui requested review from sherlockvn, hoangdat, dab246, nqhhdev, tddang-linagora and Te-Z as code owners May 31, 2024 14:58

hieutbui temporarily deployed to PR-1842 May 31, 2024 14:59 — with GitHub Actions Inactive

hieutbui temporarily deployed to PR-1842 May 31, 2024 15:04 — with GitHub Actions Inactive

hieutbui temporarily deployed to PR-1842 May 31, 2024 15:10 — with GitHub Actions Inactive

hieutbui changed the title ~~[WIP] TW-1787: Improve when leave chat~~ TW-1787: Improve when leave chat Jun 3, 2024

sherlockvn reviewed Jun 3, 2024

View reviewed changes

lib/widgets/context_menu/context_menu_action.dart Outdated Show resolved Hide resolved

nqhhdev reviewed Jun 3, 2024

View reviewed changes

lib/widgets/mixins/twake_context_menu_mixin.dart Outdated Show resolved Hide resolved

hieutbui temporarily deployed to PR-1842 June 4, 2024 04:09 — with GitHub Actions Inactive

sherlockvn approved these changes Jun 4, 2024

View reviewed changes

sherlockvn reviewed Jun 4, 2024

View reviewed changes

lib/widgets/mixins/twake_context_menu_mixin.dart Outdated Show resolved Hide resolved

hieutbui temporarily deployed to PR-1842 June 4, 2024 08:53 — with GitHub Actions Inactive

nqhhdev reviewed Jun 5, 2024

View reviewed changes

lib/widgets/context_menu/twake_context_menu.dart Outdated Show resolved Hide resolved

nqhhdev reviewed Jun 5, 2024

View reviewed changes

lib/widgets/context_menu/twake_context_menu.dart Outdated Show resolved Hide resolved

sherlockvn approved these changes Jun 6, 2024

View reviewed changes

hieutbui temporarily deployed to PR-1842 June 6, 2024 03:04 — with GitHub Actions Inactive

TW-1787: Move UI of action items into context menu widget

70751d3

hieutbui added 3 commits June 7, 2024 09:43

TW-1787: Update context menu for chat screen

1e75ab6

TW-1787: Update context menu for chat list

9068e6e

TW-1787: Update context menu for pinned screen

d224735

hieutbui force-pushed the TW-1787-Improve-when-leave-chat branch from c569cf3 to d224735 Compare June 7, 2024 02:43

hieutbui deployed to PR-1842 June 7, 2024 02:43 — with GitHub Actions View deployment

nqhhdev approved these changes Jun 7, 2024

View reviewed changes

Te-Z approved these changes Jun 10, 2024

View reviewed changes

Te-Z merged commit ede1513 into main Jun 10, 2024
7 checks passed

Te-Z deleted the TW-1787-Improve-when-leave-chat branch June 10, 2024 17:04

hieutbui mentioned this pull request Jun 21, 2024

[Bug] Clicking Report message doesn't do anything #1838

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TW-1787: Improve when leave chat #1842

TW-1787: Improve when leave chat #1842

hieutbui commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024

sherlockvn commented Jun 3, 2024

hieutbui commented Jun 3, 2024

sherlockvn commented Jun 3, 2024

nqhhdev commented Jun 3, 2024

nqhhdev commented Jun 3, 2024 •

edited

Loading

nqhhdev commented Jun 3, 2024 •

edited

Loading

hieutbui commented Jun 4, 2024

Te-Z commented Jun 6, 2024

hieutbui commented Jun 7, 2024

nqhhdev left a comment

TW-1787: Improve when leave chat #1842

TW-1787: Improve when leave chat #1842

Conversation

hieutbui commented May 31, 2024 • edited Loading

Ticket

Root cause

Solution

Resolved

github-actions bot commented May 31, 2024

sherlockvn commented Jun 3, 2024

hieutbui commented Jun 3, 2024

sherlockvn commented Jun 3, 2024

nqhhdev commented Jun 3, 2024

nqhhdev commented Jun 3, 2024 • edited Loading

Test

Web

Mobile

nqhhdev commented Jun 3, 2024 • edited Loading

hieutbui commented Jun 4, 2024

Te-Z commented Jun 6, 2024

hieutbui commented Jun 7, 2024

nqhhdev left a comment

Choose a reason for hiding this comment

hieutbui commented May 31, 2024 •

edited

Loading

nqhhdev commented Jun 3, 2024 •

edited

Loading

nqhhdev commented Jun 3, 2024 •

edited

Loading